Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org,
	Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org,
	Kai Vehmanen <kai.vehmanen@linux.intel.com>,
	Bard Liao <yung-chuan.liao@linux.intel.com>,
	"T, Arun" <arun.t@intel.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: [PATCH 5/5] ALSA: hda/i915: extend connectivity check to cover Intel ARL
Date: Wed,  2 Aug 2023 10:01:05 -0500	[thread overview]
Message-ID: <20230802150105.24604-6-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20230802150105.24604-1-pierre-louis.bossart@linux.intel.com>

From: Kai Vehmanen <kai.vehmanen@linux.intel.com>

Expand the HDA/I915 connectivity check to correctly handle
the PCI topology used in some Intel Arrow Lake products.

Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Tested-by: "T, Arun" <arun.t@intel.com>
Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
 sound/hda/hdac_i915.c | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/sound/hda/hdac_i915.c b/sound/hda/hdac_i915.c
index 2a451ff4fe6a..b428537f284c 100644
--- a/sound/hda/hdac_i915.c
+++ b/sound/hda/hdac_i915.c
@@ -75,16 +75,22 @@ static bool connectivity_check(struct pci_dev *i915, struct pci_dev *hdac)
 	if (bus_a == bus_b)
 		return true;
 
+	bus_a = bus_a->parent;
+	bus_b = bus_b->parent;
+
+	/* connected via parent bus (may be NULL!) */
+	if (bus_a == bus_b)
+		return true;
+
+	if (!bus_a || !bus_b)
+		return false;
+
 	/*
 	 * on i915 discrete GPUs with embedded HDA audio, the two
 	 * devices are connected via 2nd level PCI bridge
 	 */
 	bus_a = bus_a->parent;
 	bus_b = bus_b->parent;
-	if (!bus_a || !bus_b)
-		return false;
-	bus_a = bus_a->parent;
-	bus_b = bus_b->parent;
 	if (bus_a && bus_a == bus_b)
 		return true;
 
-- 
2.39.2


  parent reply	other threads:[~2023-08-02 15:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-02 15:01 [PATCH 0/5] ALSA/PCI: hda: add ARL-S support, config for MTL/LNL Pierre-Louis Bossart
2023-08-02 15:01 ` [PATCH 1/5] PCI: add ArrowLake-S PCI ID for Intel HDAudio subsystem Pierre-Louis Bossart
2023-08-02 15:52   ` Bjorn Helgaas
2023-08-02 15:57     ` Takashi Iwai
2023-08-02 16:07       ` Pierre-Louis Bossart
2023-08-02 16:25         ` Bjorn Helgaas
2023-08-02 16:34           ` Mark Brown
2023-08-02 18:14             ` Pierre-Louis Bossart
2023-08-02 15:01 ` [PATCH 2/5] ALSA: hda: add HD Audio PCI ID for Intel Arrow Lake-S Pierre-Louis Bossart
2023-08-02 15:01 ` [PATCH 3/5] ALSA: hda: intel-dsp-cfg: use common include for MeteorLake Pierre-Louis Bossart
2023-08-02 15:01 ` [PATCH 4/5] ALSA: hda: intel-dsp-cfg: add LunarLake support Pierre-Louis Bossart
2023-08-02 15:01 ` Pierre-Louis Bossart [this message]
2023-08-04 11:10 ` [PATCH 0/5] ALSA/PCI: hda: add ARL-S support, config for MTL/LNL Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230802150105.24604-6-pierre-louis.bossart@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=arun.t@intel.com \
    --cc=bhelgaas@google.com \
    --cc=broonie@kernel.org \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=tiwai@suse.de \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox