From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCD66C001DF for ; Wed, 2 Aug 2023 16:25:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230010AbjHBQZq (ORCPT ); Wed, 2 Aug 2023 12:25:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229932AbjHBQZp (ORCPT ); Wed, 2 Aug 2023 12:25:45 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E721E2119 for ; Wed, 2 Aug 2023 09:25:44 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7CE9E61A25 for ; Wed, 2 Aug 2023 16:25:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A02DDC433C7; Wed, 2 Aug 2023 16:25:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690993543; bh=z2GNkrzDnIZ2M8EG2mnGFYrFGtYzhPvZFKvGFeCBXIU=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=gFjLP5bPL5szB0HXuK48OR27CZJS9vooMh2M1jijAUj/eQTB8619rus9DX4ZrIx94 fK8vueua5+1f17fm7VUy+IFf+jsSJbYGhbR4QtXgxNCt9OcRLpAICNJCSGVqZmBrzS 0ndOLdGu9SbdlYgRX+DjzIK6D1/5V3AkLPvnf1jOjD7xdoSuWQn14/CiiN5Hh72ywi WEprz8UDVlLsO18B0LhhlDUXHoEAVcyVbPPKQQVdAW1bGUWKd1D2qTqU4geB+5nPle FTEVBXHx1GZkbkxsrpODFjAbfIY1AesCzjh4SRqR0OzUHASzgUHL/AMzRdQO9McIKk sQ2U7kuMbkzyg== Date: Wed, 2 Aug 2023 11:25:41 -0500 From: Bjorn Helgaas To: Pierre-Louis Bossart Cc: Takashi Iwai , alsa-devel@alsa-project.org, broonie@kernel.org, Bjorn Helgaas , linux-pci@vger.kernel.org, Ranjani Sridharan , Bard Liao Subject: Re: [PATCH 1/5] PCI: add ArrowLake-S PCI ID for Intel HDAudio subsystem. Message-ID: <20230802162541.GA60855@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <206f5a15-29f0-ec7c-1b85-50ace8ae7c2f@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, Aug 02, 2023 at 11:07:36AM -0500, Pierre-Louis Bossart wrote: > On 8/2/23 10:57, Takashi Iwai wrote: > > On Wed, 02 Aug 2023 17:52:26 +0200, > > Bjorn Helgaas wrote: > >> On Wed, Aug 02, 2023 at 10:01:01AM -0500, Pierre-Louis Bossart wrote: > >>> Add part ID to common include file > >> > >> Please drop period at end of subject and add one at the end of the > >> commit log. > >> > >> Also mention the drivers that will use this new #define; looks like > >> hda_intel.c and ... > >> > >> Well, actually, I only see that one use, which means we probably > >> shouldn't add this #define to pci_ids.h, per the comment at the top of > >> the file. If there's only one use, use the hex ID in the driver (or > >> add a #define in the driver itself). > > > > Judging from the previous patterns, the same ID could be required for > > ASoC SOF driver, too, which isn't included in this patch set. In > > that case, it's worth to put to pci_ids.h. > > (OTOH, it can be done at a later stage, too.) When it becomes shared is the standard point at which we add to pci_ids.h. > I am not following. we just agreed a couple of weeks ago to record ALL > Intel/HDaudio PCI IDs in the same pci_ids.h include file. I'm not sure who "we" is here. If it included me and I signed up to it, I apologize for forgetting, and go ahead and add my: Acked-by: Bjorn Helgaas I'm just pointing out the usual practice for pci_ids.h, as mentioned in the file itself. > ArrowLake-S is the first addition to first file after the work done by > Cezary/Amadeusz. Yes it's required to be added since it'll be used in > other parts later on. But even if there was ONE use of this PCI ID, why > would we not add it for consistency to the global pci_ids.h file? > Takashi's hda_intel.c file would look really bad if we have a mix of > single-use PCIs and shared ones... We already have a mix: static const struct pci_device_id azx_ids[] = { /* CPT */ { PCI_DEVICE(0x8086, 0x1c20), .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH_NOPM }, /* PBG */ { PCI_DEVICE(0x8086, 0x1d20), .driver_data = AZX_DRIVER_PCH | AZX_DCAPS_INTEL_PCH_NOPM }, /* Panther Point */ I think the reason we don't add names used only once is because it makes backporting things harder because it leads to more merge conflicts in pci_ids.h. Bjorn