From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DEC6C04A6A for ; Tue, 8 Aug 2023 18:00:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235217AbjHHSAO (ORCPT ); Tue, 8 Aug 2023 14:00:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229920AbjHHR7n (ORCPT ); Tue, 8 Aug 2023 13:59:43 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C55D72CEE2 for ; Tue, 8 Aug 2023 09:27:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 531B062531 for ; Tue, 8 Aug 2023 16:26:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71430C433B7; Tue, 8 Aug 2023 16:26:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691511989; bh=zE/uSYeRloetY2ZRpWdkDWpaPNmX2Vprz3+Hc9pFNr8=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=Sjdz06csNVGed3j66FD4E/PDkuW6p4aJDFTASGiBQPnqYPMIcBAKLqdysbMQqSGSj Vr60OZ3318kwP8ODF2E8XcwylDOyDCIuuhhha7vfn24K0HNilLiRd0p0TJvmmCDf4q PzutiWTgmR9s2XhbbObOl+ZnWfKF21ZcB4nOC1LkkOdXYuzjK6McaPjFAwvimVJ7qc 4sbBlNPB6fy3zfBF+yxgbTOtoRHWlaAzr7V6ZkLGLQsoAeTb0Dc81xM0/putFxpyCC eGLnfxkHj0+g+njPF9/QrW+TT66W4OV1B3dqcx58PwF4rvi83hx3sT63JZgC2AUHyu aV2sreGd2MOKg== Date: Tue, 8 Aug 2023 11:26:27 -0500 From: Bjorn Helgaas To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: "Russell King (Oracle)" , Lorenzo Pieralisi , Bjorn Helgaas , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] PCI: mvebu: Mark driver as BROKEN Message-ID: <20230808162627.GA314706@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230808072605.n3rjfsxuogza7qth@pali> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org [+cc linux-arm-kernel, beginning of thread: https://lore.kernel.org/r/20230114164125.1298-1-pali@kernel.org] On Tue, Aug 08, 2023 at 09:26:05AM +0200, Pali Rohár wrote: > On Friday 04 August 2023 12:35:13 Russell King (Oracle) wrote: > ... > > For example, I have an Atheros PCIe WiFi card in an Armada 388 Clearfog > > platform, and this works fine. > > > > Uwe has a SATA controller for a bunch of disks in an Armada 370 based > > NAS platform that is connected to PCIe, and removing PCIe support > > effectively makes his platform utterly useless. > > > > Please revert this patch. > > Please do not revert it, instead start fixing problems. We know that like all the other drivers, the mvebu driver isn't perfect. But I don't think effectively removing the driver completely helps anybody. If people try to use it and notice problems, we have a chance to try to fix them. Or maybe I'm missing your point. I think you're suggesting that we keep pci-mvebu in the tree but unselectable because it depends on CONFIG_BROKEN. What would be the advantage of doing that? Bjorn