From: Bjorn Helgaas <helgaas@kernel.org>
To: Sui Jingfeng <suijingfeng@loongson.cn>
Cc: Huacai Chen <chenhuacai@kernel.org>,
WANG Xuerui <kernel@xen0n.name>,
Jianmin Lv <lvjianmin@loongson.cn>,
loongarch@lists.linux.dev, linux-kernel@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>, Li Yi <liyi@loongson.cn>,
linux-pci@vger.kernel.org, loongson-kernel@lists.loongnix.cn
Subject: Re: [PATCH] LoongArch: Remove vgaarb related workarounds
Date: Fri, 11 Aug 2023 17:55:00 -0500 [thread overview]
Message-ID: <20230811225500.GA118486@bhelgaas> (raw)
In-Reply-To: <20230801185607.703295-1-suijingfeng@loongson.cn>
On Wed, Aug 02, 2023 at 02:56:07AM +0800, Sui Jingfeng wrote:
> When we have a better approach[1] to handle multiple video cards problems
> on Loongarch, we want to drop the vgaarb related workaround.
>
> [1] https://patchwork.freedesktop.org/patch/550708/?series=121740&rev=1
If I understand correctly, this patch depends on [1]. The way you do
this is to send both patches in a single series, e.g.,
[PATCH 0/2] <cover letter>
[PATCH 1/2] PCI/VGA: Make the vga_is_firmware_default() less arch-independent
[PATCH 2/2] LoongArch: Remove vgaarb related workarounds
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Li Yi <liyi@loongson.cn>
> Cc: linux-pci@vger.kernel.org
> Cc: loongson-kernel@lists.loongnix.cn
> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
> ---
> arch/loongarch/pci/pci.c | 19 -------------------
> 1 file changed, 19 deletions(-)
>
> diff --git a/arch/loongarch/pci/pci.c b/arch/loongarch/pci/pci.c
> index 2726639150bc..4319b5d75872 100644
> --- a/arch/loongarch/pci/pci.c
> +++ b/arch/loongarch/pci/pci.c
> @@ -8,13 +8,10 @@
> #include <linux/acpi.h>
> #include <linux/types.h>
> #include <linux/pci.h>
> -#include <linux/vgaarb.h>
> #include <asm/cacheflush.h>
> #include <asm/loongson.h>
>
> #define PCI_DEVICE_ID_LOONGSON_HOST 0x7a00
> -#define PCI_DEVICE_ID_LOONGSON_DC1 0x7a06
> -#define PCI_DEVICE_ID_LOONGSON_DC2 0x7a36
>
> int raw_pci_read(unsigned int domain, unsigned int bus, unsigned int devfn,
> int reg, int len, u32 *val)
> @@ -82,19 +79,3 @@ int pcibios_alloc_irq(struct pci_dev *dev)
> return 0;
> return acpi_pci_irq_enable(dev);
> }
> -
> -static void pci_fixup_vgadev(struct pci_dev *pdev)
> -{
> - struct pci_dev *devp = NULL;
> -
> - while ((devp = pci_get_class(PCI_CLASS_DISPLAY_VGA << 8, devp))) {
> - if (devp->vendor != PCI_VENDOR_ID_LOONGSON) {
> - vga_set_default_device(devp);
> - dev_info(&pdev->dev,
> - "Overriding boot device as %X:%X\n",
> - devp->vendor, devp->device);
> - }
> - }
> -}
> -DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_LOONGSON, PCI_DEVICE_ID_LOONGSON_DC1, pci_fixup_vgadev);
> -DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_LOONGSON, PCI_DEVICE_ID_LOONGSON_DC2, pci_fixup_vgadev);
> --
> 2.34.1
>
prev parent reply other threads:[~2023-08-11 22:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 18:56 [PATCH] LoongArch: Remove vgaarb related workarounds Sui Jingfeng
2023-08-11 22:55 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230811225500.GA118486@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=chenhuacai@kernel.org \
--cc=kernel@xen0n.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liyi@loongson.cn \
--cc=loongarch@lists.linux.dev \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=lvjianmin@loongson.cn \
--cc=suijingfeng@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox