From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85742C3DA66 for ; Fri, 25 Aug 2023 11:26:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238894AbjHYLZv (ORCPT ); Fri, 25 Aug 2023 07:25:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53744 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240609AbjHYLZV (ORCPT ); Fri, 25 Aug 2023 07:25:21 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2D231FEC; Fri, 25 Aug 2023 04:25:19 -0700 (PDT) Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4RXHZ53vkKz6K6C2; Fri, 25 Aug 2023 19:20:45 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Fri, 25 Aug 2023 12:25:16 +0100 Date: Fri, 25 Aug 2023 12:25:16 +0100 From: Jonathan Cameron To: Yicong Yang CC: , , , , , , , , , Subject: Re: [PATCH 4/5] hwtracing: hisi_ptt: Don't try to attach a task Message-ID: <20230825122516.000053d8@Huawei.com> In-Reply-To: <20230809081825.11518-5-yangyicong@huawei.com> References: <20230809081825.11518-1-yangyicong@huawei.com> <20230809081825.11518-5-yangyicong@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500006.china.huawei.com (7.191.161.198) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Wed, 9 Aug 2023 16:18:24 +0800 Yicong Yang wrote: > From: Yicong Yang > > PTT is an uncore PMU and shouldn't be attached to any task. Block > the usage in pmu::event_init(). > > Signed-off-by: Yicong Yang Acked-by: Jonathan Cameron > --- > drivers/hwtracing/ptt/hisi_ptt.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/hwtracing/ptt/hisi_ptt.c b/drivers/hwtracing/ptt/hisi_ptt.c > index 3aba7bb6e548..916686c6a9c8 100644 > --- a/drivers/hwtracing/ptt/hisi_ptt.c > +++ b/drivers/hwtracing/ptt/hisi_ptt.c > @@ -1003,6 +1003,9 @@ static int hisi_ptt_pmu_event_init(struct perf_event *event) > return -EOPNOTSUPP; > } > > + if (event->attach_state & PERF_ATTACH_TASK) > + return -EOPNOTSUPP; > + > if (event->attr.type != hisi_ptt->hisi_ptt_pmu.type) > return -ENOENT; >