* [PATCH] PCI: vmd: Clean up an indentation issue reported by Smatch
@ 2023-06-27 11:38 korantwork
2023-08-30 8:38 ` Krzysztof Wilczyński
0 siblings, 1 reply; 2+ messages in thread
From: korantwork @ 2023-06-27 11:38 UTC (permalink / raw)
To: kw, nirmal.patel; +Cc: linux-kernel, hch, linux-pci, Xinghui Li, Dan Carpenter
From: Xinghui Li <korantli@tencent.com>
There is one inconsistent indenting warning:
"drivers/pci/controller/vmd.c:1058 vmd_resume()
warn: inconsistent indenting"
Fix it and remove the unnecessary if.
Reported-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Xinghui Li <korantli@tencent.com>
---
drivers/pci/controller/vmd.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c
index 990630ec57c6..356bbeb548fe 100644
--- a/drivers/pci/controller/vmd.c
+++ b/drivers/pci/controller/vmd.c
@@ -1055,10 +1055,7 @@ static int vmd_resume(struct device *dev)
struct vmd_dev *vmd = pci_get_drvdata(pdev);
int err, i;
- if (vmd->irq_domain)
- vmd_set_msi_remapping(vmd, true);
- else
- vmd_set_msi_remapping(vmd, false);
+ vmd_set_msi_remapping(vmd, !!vmd->irq_domain);
for (i = 0; i < vmd->msix_count; i++) {
err = devm_request_irq(dev, vmd->irqs[i].virq,
--
2.39.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] PCI: vmd: Clean up an indentation issue reported by Smatch
2023-06-27 11:38 [PATCH] PCI: vmd: Clean up an indentation issue reported by Smatch korantwork
@ 2023-08-30 8:38 ` Krzysztof Wilczyński
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Wilczyński @ 2023-08-30 8:38 UTC (permalink / raw)
To: korantwork
Cc: nirmal.patel, linux-kernel, hch, linux-pci, Xinghui Li,
Dan Carpenter
Hello,
> There is one inconsistent indenting warning:
> "drivers/pci/controller/vmd.c:1058 vmd_resume()
> warn: inconsistent indenting"
>
> Fix it and remove the unnecessary if.
Applied to controller/vmd, thank you!
[1/1] PCI: vmd: Fix inconsistent indentation in vmd_resume()
https://git.kernel.org/pci/pci/c/1bae18a3eeee
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-30 18:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-27 11:38 [PATCH] PCI: vmd: Clean up an indentation issue reported by Smatch korantwork
2023-08-30 8:38 ` Krzysztof Wilczyński
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).