From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2759ECD37B0 for ; Mon, 18 Sep 2023 10:55:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230517AbjIRKzG convert rfc822-to-8bit (ORCPT ); Mon, 18 Sep 2023 06:55:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234888AbjIRKyq (ORCPT ); Mon, 18 Sep 2023 06:54:46 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B88EB115; Mon, 18 Sep 2023 03:54:13 -0700 (PDT) Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Rq1ks3Z2Qz6J7Db; Mon, 18 Sep 2023 18:49:25 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Mon, 18 Sep 2023 11:54:11 +0100 Date: Mon, 18 Sep 2023 11:54:10 +0100 From: Jonathan Cameron To: Andy Shevchenko CC: Herve Codina , Rob Herring , Lizhi Hou , Andrew Lunn , , , , , , Subject: Re: [PATCH V13 0/5] Generate device tree node for pci devices Message-ID: <20230918115410.00007421@Huawei.com> In-Reply-To: References: <1692120000-46900-1-git-send-email-lizhi.hou@amd.com> <20230915193008.6d87b8a0@bootlin.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml100004.china.huawei.com (7.191.162.219) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, 18 Sep 2023 10:17:26 +0300 Andy Shevchenko wrote: > On Fri, Sep 15, 2023 at 07:30:08PM +0200, Herve Codina wrote: > > On Wed, 13 Sep 2023 14:17:30 +0300 > > Andy Shevchenko wrote: > > > On Tue, Sep 12, 2023 at 02:12:04PM -0500, Rob Herring wrote: > > > > On Mon, Sep 11, 2023 at 3:37 PM Andy Shevchenko > > > > wrote: > > > > > On Tue, Aug 15, 2023 at 10:19:55AM -0700, Lizhi Hou wrote: > > ... > > > > > > Can you point out to the ACPI excerpt(s) of the description of anything related > > > > > to the device(s) in question? > > > > > > > > I don't understand what you are asking for. > > > > > > Through the email thread it was mentioned that this series was tested on the > > > ACPI enabled platform, Jonathan (IIRC) asked why do we need to have a shadow > > > DT for the something that ACPI already describes. That's why I'm trying to > > > understand if it's the case. and if so, how can we improve the approach. > > > > Patches from Frank Rowand series [1] are needed to create an of_root_node if a DT > > was not provided by the firmware, bootloader, etc that run the kernel. > > > > [1]: https://lore.kernel.org/lkml/20220624034327.2542112-1-frowand.list@gmail.com/ > > > > Current Lizhi's series creates nodes from the PCI host node during the PCI > > enumeration. It creates PCI-PCI bridge and PCI device nodes. > > > > I use these series on an ACPI system. > > > > I need one more missing component: the node related to the PCI host bridge > > This was the purpose of Clement's work. This work was not sent upstream yet and I > > am working on it in order to have a full tree from the of_root to the PCI device > > ie: > > of_root <-- Frank Rowand series > > + of_host_pci_bridge <-- Clement's work > > + pci_bridge <-- Current Lizhi series > > + pci_bridge <-- Current Lizhi series > > ... > > + pci_dev <-- Current Lizhi series > > > > Hope that this status helped. > > Thanks for the explanation! I suppose it's better to have three series combined > into one and being sent with a better cover letter to explain all this. Also it > might make sense (in my opinion) to Cc Jonathan (I did it here). Sorry, Jonathan, > if you are not wanting this. > I'm lurking anyway via linux-pci :) Indeed very interested in this. I'm carrying a local copy of Clement's series but more than happy if Herve gets that bit ready for upstream. I think we are still some way from this all working for a non trivial PCI card on an ACPI system though. Maybe I'm wrong and the rest will turn out to be easy! Jonathan