From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Vidya Sagar <vidyas@nvidia.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Michael Bottini <michael.a.bottini@linux.intel.com>,
"David E . Box" <david.e.box@linux.intel.com>,
Tasev Nikola <tasev.stefanoska@skynet.be>,
Mark Enriquez <enriquezmark36@gmail.com>,
Thomas Witt <kernel@witt.link>, Koba Ko <koba.ko@canonical.com>,
Werner Sembach <wse@tuxedocomputers.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v2] PCI/ASPM: Add back L1 PM Substate save and restore
Date: Mon, 18 Sep 2023 15:22:52 +0300 [thread overview]
Message-ID: <20230918122252.GT1599918@black.fi.intel.com> (raw)
In-Reply-To: <28b140a3-8fe9-373d-d66f-20ab104230cc@linux.intel.com>
Hi Ilpo,
On Mon, Sep 18, 2023 at 03:17:41PM +0300, Ilpo Järvinen wrote:
> > > > + */
> > > > + val = cap[1] & PCI_EXP_LNKCTL_ASPMC;
>
> Given this line, it just felt pretty obvious because why would the code
> & PCI_EXP_LNKCTL_* with some random register (value) that isn't LNKCTL :-).
That's a fair point :) Okay I can drop the comment in the next version.
next prev parent reply other threads:[~2023-09-18 12:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 7:33 [PATCH v2] PCI/ASPM: Add back L1 PM Substate save and restore Mika Westerberg
2023-09-18 11:46 ` Ilpo Järvinen
2023-09-18 12:09 ` Mika Westerberg
2023-09-18 12:17 ` Ilpo Järvinen
2023-09-18 12:22 ` Mika Westerberg [this message]
2023-09-22 3:52 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230918122252.GT1599918@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=david.e.box@linux.intel.com \
--cc=enriquezmark36@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=kai.heng.feng@canonical.com \
--cc=kernel@witt.link \
--cc=koba.ko@canonical.com \
--cc=linux-pci@vger.kernel.org \
--cc=michael.a.bottini@linux.intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=tasev.stefanoska@skynet.be \
--cc=vidyas@nvidia.com \
--cc=wse@tuxedocomputers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox