From: Bjorn Helgaas <helgaas@kernel.org>
To: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: linux-sh@vger.kernel.org, linux-pci@vger.kernel.org,
glaubitz@physik.fu-berlin.de
Subject: Re: [RFC PATCH v2 06/30] drivers/pci: SH7751 PCI Host bridge header.
Date: Mon, 18 Sep 2023 14:16:02 -0500 [thread overview]
Message-ID: <20230918191602.GA201859@bhelgaas> (raw)
In-Reply-To: <b738791694e216841f0db37c10b8e37e3e51526b.1694596125.git.ysato@users.sourceforge.jp>
On Wed, Sep 13, 2023 at 06:23:31PM +0900, Yoshinori Sato wrote:
> This file move from SH specific directory "arch/sh/drivers/pci/pci-sh7751.h"
>
> Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
> ---
> drivers/pci/controller/pci-sh7751.h | 270 ++++++++++++++++++++++++++++
> 1 file changed, 270 insertions(+)
> create mode 100644 drivers/pci/controller/pci-sh7751.h
If this is a move from arch/sh/drivers/pci/, shouldn't this diff show
both the removal and the addition? Or even better, if you use "git
mv", won't it show the move directly, without a diff at all?
This file is only used in one place, so please just incorporate it
directly into pci-sh7751.c. I think the git history would be a little
cleaner if you did this as a separate patch before moving it to
drivers/pci/.
If you're moving things into drivers/pci/, follow the subject line
conventions (see "git log --oneline drivers/pci/controller/"):
- No period at end of subject line
- Subject line begins with "PCI: <driver-tag>: <Verb> ...", e.g.,
PCI: sh7751: Add SH7751 driver
> diff --git a/drivers/pci/controller/pci-sh7751.h b/drivers/pci/controller/pci-sh7751.h
> new file mode 100644
> index 000000000000..9b7de8243e92
> --- /dev/null
> +++ b/drivers/pci/controller/pci-sh7751.h
> @@ -0,0 +1,270 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Low-Level PCI Support for SH7751 targets
> + *
> + * Dustin McIntire (dustin@sensoria.com) (c) 2001
> + * Paul Mundt (lethal@linux-sh.org) (c) 2003
> + *
> + * May be copied or modified under the terms of the GNU General Public
> + * License. See linux/COPYING for more information.
Unnecessary text, given the SPDX header above.
> + *
Spurious blank line.
> +/* Platform Specific Values */
> +#define SH7751_VENDOR_ID 0x1054
> +#define SH7751_DEVICE_ID 0x3505
> +#define SH7751R_DEVICE_ID 0x350e
Most of this file uses upper-case hex, so use it consistently.
Bjorn
next prev parent reply other threads:[~2023-09-18 19:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1694596125.git.ysato@users.sourceforge.jp>
2023-09-13 9:23 ` [RFC PATCH v2 06/30] drivers/pci: SH7751 PCI Host bridge header Yoshinori Sato
2023-09-18 19:16 ` Bjorn Helgaas [this message]
2023-09-13 9:23 ` [RFC PATCH v2 07/30] drivers/pci: SH7751 PCI Host bridge controller driver Yoshinori Sato
2023-09-18 15:32 ` Geert Uytterhoeven
2023-09-20 12:15 ` Yoshinori Sato
2023-09-18 19:30 ` Bjorn Helgaas
2023-09-13 9:23 ` [RFC PATCH v2 08/30] drivers/pci: Add SH7751 Host bridge controller Yoshinori Sato
2023-09-18 15:34 ` Geert Uytterhoeven
2023-09-18 19:33 ` Bjorn Helgaas
2023-10-12 7:16 ` Geert Uytterhoeven
2023-09-13 9:23 ` [RFC PATCH v2 09/30] Documentation/devicetree: Add renesas,sh7751-pci binding document Yoshinori Sato
2023-09-13 10:42 ` Krzysztof Kozlowski
2023-09-18 15:41 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230918191602.GA201859@bhelgaas \
--to=helgaas@kernel.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-pci@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).