From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CA4AE7D0A2 for ; Thu, 21 Sep 2023 18:12:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230376AbjIUSMJ (ORCPT ); Thu, 21 Sep 2023 14:12:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230044AbjIUSLS (ORCPT ); Thu, 21 Sep 2023 14:11:18 -0400 Received: from bmailout1.hostsharing.net (bmailout1.hostsharing.net [83.223.95.100]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08F1C8AE1F for ; Thu, 21 Sep 2023 10:41:07 -0700 (PDT) Received: from h08.hostsharing.net (h08.hostsharing.net [83.223.95.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL Global TLS RSA4096 SHA256 2022 CA1" (verified OK)) by bmailout1.hostsharing.net (Postfix) with ESMTPS id 60CAC30010D5E; Thu, 21 Sep 2023 17:14:01 +0200 (CEST) Received: by h08.hostsharing.net (Postfix, from userid 100393) id 53B185D6FD8; Thu, 21 Sep 2023 17:14:01 +0200 (CEST) Date: Thu, 21 Sep 2023 17:14:01 +0200 From: Lukas Wunner To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org Subject: Re: Make Bjorn's life easier (and grease the path of your patch) Message-ID: <20230921151401.GA25512@wunner.de> References: <20171026223701.GA25649@bhelgaas-glaptop.roam.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171026223701.GA25649@bhelgaas-glaptop.roam.corp.google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi Bjorn, On Thu, Oct 26, 2017 at 05:37:01PM -0500, Bjorn Helgaas wrote: > This is a list of things I look at when reviewing patches. [...] > Write the changelog: [...] > - Order tags as suggested by Ingo [1] (extended): > > Fixes: > Link: > Reported-by: > Tested-by: > Signed-off-by: (author) > Signed-off-by: (chain) > Reviewed-by: > Acked-by: > Cc: stable@vger.kernel.org # 3.4+ > Cc: (other) I've used your message from 2017 [1] as a reference on how to order tags but today discovered that checkpatch.pl has a new rule which is sort of at odds with your preferred style: WARNING: Reported-by: should be immediately followed by Closes: with a URL to the report #38: Reported-by: Chad Schroeder Tested-by: Chad Schroeder total: 0 errors, 1 warnings, 15 lines checked I'm not sure where to insert the Closes tag, checkpatch wants it immediately after the Reported-by, but since Closes is like Link, I'd assume that you'd prefer it to precede the Reported-by. I've pointed other folks to your message so that they know which guidelines to observe when submitting to linux-pci. I'd like to encourage you to update it and (if you like) add it to the tree as a maintainer profile (see Documentation/maintainer/maintainer-entry-profile.rst) so that it's even easier to find. [1] https://lore.kernel.org/linux-pci/20171026223701.GA25649@bhelgaas-glaptop.roam.corp.google.com/ Thanks! Lukas