From: Bjorn Helgaas <helgaas@kernel.org>
To: Thorsten Leemhuis <regressions@leemhuis.info>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Lukas Wunner <lukas@wunner.de>,
Mark Blakeney <mark.blakeney@bullet-systems.net>,
Kamil Paral <kparal@redhat.com>,
Chris Chiu <chris.chiu@canonical.com>,
linux-pci@vger.kernel.org,
Linux kernel regressions list <regressions@lists.linux.dev>
Subject: Re: [PATCH] PCI/PM: Mark devices disconnected if their upstream PCIe link is down on resume
Date: Fri, 22 Sep 2023 07:41:12 -0500 [thread overview]
Message-ID: <20230922124112.GA367772@bhelgaas> (raw)
In-Reply-To: <785cbc11-3d85-4551-8290-0ca31e9be77e@leemhuis.info>
On Fri, Sep 22, 2023 at 01:45:58PM +0200, Thorsten Leemhuis wrote:
> On 21.09.23 22:19, Bjorn Helgaas wrote:
> > On Mon, Sep 18, 2023 at 08:30:41AM +0300, Mika Westerberg wrote:
> >> Mark Blakeney reported that when suspending system with a Thunderbolt
> >> dock connected and then unplugging the dock before resume (which is
> >> pretty normal flow with laptops), resuming takes long time.
> >>
> >> What happens is that the PCIe link from the root port to the PCIe switch
> >> inside the Thunderbolt device does not train (as expected, the link is
> >> upplugged):
> > [...]
> >> Fixes: e8b908146d44 ("PCI/PM: Increase wait time after resume")
> >> Reported-by: Mark Blakeney <mark.blakeney@bullet-systems.net>
> >> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217915
> >> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> >
> > Applied with Lukas' Reviewed-by to pm for v6.7.
> >
> > e8b908146d44 appeared in v6.4.
>
> Then why did you apply this for 6.7 and not to a branch targeting the
> current cycle? Linus wants regression introduced during round about the
> last 12 months to be handled liked regressions from the current cycle,
I was not aware of the last 12 months rule. Happy to change if that's
the guideline. My previous rule of thumb was: fixes for regressions
in the most recent merge window always go to current cycle, fixes for
older regressions case-by-case.
Bjorn
next prev parent reply other threads:[~2023-09-22 12:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 5:30 [PATCH] PCI/PM: Mark devices disconnected if their upstream PCIe link is down on resume Mika Westerberg
2023-09-18 8:37 ` Lukas Wunner
2023-09-21 20:19 ` Bjorn Helgaas
2023-09-22 4:42 ` Mika Westerberg
2023-09-22 12:59 ` Bjorn Helgaas
2023-09-24 13:44 ` Mika Westerberg
2023-09-22 11:45 ` Thorsten Leemhuis
2023-09-22 12:41 ` Bjorn Helgaas [this message]
2023-09-22 12:53 ` Thorsten Leemhuis
2023-09-29 22:45 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230922124112.GA367772@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=chris.chiu@canonical.com \
--cc=kparal@redhat.com \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mark.blakeney@bullet-systems.net \
--cc=mika.westerberg@linux.intel.com \
--cc=regressions@leemhuis.info \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).