From: Bjorn Helgaas <helgaas@kernel.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Lukas Wunner <lukas@wunner.de>,
Mark Blakeney <mark.blakeney@bullet-systems.net>,
Kamil Paral <kparal@redhat.com>,
Chris Chiu <chris.chiu@canonical.com>,
linux-pci@vger.kernel.org,
Thorsten Leemhuis <regressions@leemhuis.info>
Subject: Re: [PATCH] PCI/PM: Mark devices disconnected if their upstream PCIe link is down on resume
Date: Fri, 22 Sep 2023 07:59:26 -0500 [thread overview]
Message-ID: <20230922125926.GA367919@bhelgaas> (raw)
In-Reply-To: <20230922044237.GC3208943@black.fi.intel.com>
[+cc Thorsten]
On Fri, Sep 22, 2023 at 07:42:37AM +0300, Mika Westerberg wrote:
> On Thu, Sep 21, 2023 at 03:19:45PM -0500, Bjorn Helgaas wrote:
> > On Mon, Sep 18, 2023 at 08:30:41AM +0300, Mika Westerberg wrote:
> ...
> > Kamil also bisected a 60+ second resume delay to e8b908146d44
> > (https://lore.kernel.org/r/CA+cBOTeWrsTyANjLZQ=bGoBQ_yOkkV1juyRvJq-C8GOrbW6t9Q@mail.gmail.com),
> > but IIUC at
> > https://lore.kernel.org/linux-pci/20230824114300.GU3465@black.fi.intel.com/T/#u
> > you concluded that Kamil's issue was related to firmware and actually
> > had nothing to do with e8b908146d44.
> >
> > Do you still think Kamil's issue is unrelated to e8b908146d44 and this
> > patch? If so, how do we handle Kamil's issue? An answer like "users
> > of v6.4+ must upgrade their Thunderbolt firmware" seems like it would
> > be kind of a nightmare for users.
>
> It's a different issue. What happens in his system is that the link went
> down even though the dock was still connected and this should not happen
> (the firmware should bring the link up during resume). The delay was
> just a "symptom".
Do you have any leads for Kamil's issue? If we had known that
e8b908146d44 would cause that problem, we never would have applied it
in the first place.
No OS would accept that resume delay, so there must be some way to fix
that in the OS without requiring a firmware update.
If Kamil's issue is that firmware doesn't bring up the link during
resume, how *does* the link get brought up, and what does the delay
have to do with it?
Bjorn
next prev parent reply other threads:[~2023-09-22 12:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-18 5:30 [PATCH] PCI/PM: Mark devices disconnected if their upstream PCIe link is down on resume Mika Westerberg
2023-09-18 8:37 ` Lukas Wunner
2023-09-21 20:19 ` Bjorn Helgaas
2023-09-22 4:42 ` Mika Westerberg
2023-09-22 12:59 ` Bjorn Helgaas [this message]
2023-09-24 13:44 ` Mika Westerberg
2023-09-22 11:45 ` Thorsten Leemhuis
2023-09-22 12:41 ` Bjorn Helgaas
2023-09-22 12:53 ` Thorsten Leemhuis
2023-09-29 22:45 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230922125926.GA367919@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=chris.chiu@canonical.com \
--cc=kparal@redhat.com \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mark.blakeney@bullet-systems.net \
--cc=mika.westerberg@linux.intel.com \
--cc=regressions@leemhuis.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).