From: Bjorn Helgaas <helgaas@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>
Subject: Re: [PATCH v1 1/1] PCI: ACPI: Switch to use acpi_evaluate_dsm_typed()
Date: Tue, 3 Oct 2023 12:04:36 -0500 [thread overview]
Message-ID: <20231003170436.GA678206@bhelgaas> (raw)
In-Reply-To: <20231002135352.2603096-1-andriy.shevchenko@linux.intel.com>
On Mon, Oct 02, 2023 at 04:53:52PM +0300, Andy Shevchenko wrote:
> The acpi_evaluate_dsm_typed() provides a way to check the type of the
> object evaluated by _DSM call. Use it instead of open coded variant.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Applied with Rafael's ack to pci/enumeration for v6.7, thanks!
> ---
> drivers/pci/pci-acpi.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c
> index a05350a4e49c..cf108259aef6 100644
> --- a/drivers/pci/pci-acpi.c
> +++ b/drivers/pci/pci-acpi.c
> @@ -1215,12 +1215,12 @@ void acpi_pci_add_bus(struct pci_bus *bus)
> if (!pci_is_root_bus(bus))
> return;
>
> - obj = acpi_evaluate_dsm(ACPI_HANDLE(bus->bridge), &pci_acpi_dsm_guid, 3,
> - DSM_PCI_POWER_ON_RESET_DELAY, NULL);
> + obj = acpi_evaluate_dsm_typed(ACPI_HANDLE(bus->bridge), &pci_acpi_dsm_guid, 3,
> + DSM_PCI_POWER_ON_RESET_DELAY, NULL, ACPI_TYPE_INTEGER);
> if (!obj)
> return;
>
> - if (obj->type == ACPI_TYPE_INTEGER && obj->integer.value == 1) {
> + if (obj->integer.value == 1) {
> bridge = pci_find_host_bridge(bus);
> bridge->ignore_reset_delay = 1;
> }
> @@ -1376,12 +1376,13 @@ static void pci_acpi_optimize_delay(struct pci_dev *pdev,
> if (bridge->ignore_reset_delay)
> pdev->d3cold_delay = 0;
>
> - obj = acpi_evaluate_dsm(handle, &pci_acpi_dsm_guid, 3,
> - DSM_PCI_DEVICE_READINESS_DURATIONS, NULL);
> + obj = acpi_evaluate_dsm_typed(handle, &pci_acpi_dsm_guid, 3,
> + DSM_PCI_DEVICE_READINESS_DURATIONS, NULL,
> + ACPI_TYPE_PACKAGE);
> if (!obj)
> return;
>
> - if (obj->type == ACPI_TYPE_PACKAGE && obj->package.count == 5) {
> + if (obj->package.count == 5) {
> elements = obj->package.elements;
> if (elements[0].type == ACPI_TYPE_INTEGER) {
> value = (int)elements[0].integer.value / 1000;
> --
> 2.40.0.1.gaa8946217a0b
>
prev parent reply other threads:[~2023-10-03 17:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 13:53 [PATCH v1 1/1] PCI: ACPI: Switch to use acpi_evaluate_dsm_typed() Andy Shevchenko
2023-10-03 13:49 ` Rafael J. Wysocki
2023-10-03 17:04 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231003170436.GA678206@bhelgaas \
--to=helgaas@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).