From: Bjorn Helgaas <helgaas@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "Jingoo Han" <jingoohan1@gmail.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>,
"Kukjin Kim" <kgene.kim@samsung.com>,
"Siva Reddy Kallam" <siva.kallam@samsung.com>,
"Surendranath Gurivireddy Balla" <suren.reddy@samsung.com>,
"Xiaowei Song" <songxiaowei@hisilicon.com>,
"Binghui Wang" <wangbinghui@hisilicon.com>,
"Kishon Vijay Abraham I" <kishon@ti.com>,
"Mauro Carvalho Chehab" <mchehab+huawei@kernel.org>,
"Santosh Shilimkar" <santosh.shilimkar@ti.com>,
"Murali Karicheri" <m-karicheri2@ti.com>,
"Rob Herring" <robh@kernel.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH 0/4] pci: Fix some section mismatches
Date: Tue, 10 Oct 2023 12:23:46 -0500 [thread overview]
Message-ID: <20231010172346.GA984693@bhelgaas> (raw)
In-Reply-To: <20231001170254.2506508-1-u.kleine-koenig@pengutronix.de>
On Sun, Oct 01, 2023 at 07:02:50PM +0200, Uwe Kleine-König wrote:
> Hello,
>
> modpost checks about section mismatches are about to get stronger, see
> https://lore.kernel.org/linux-kbuild/20230930165204.2478282-1-u.kleine-koenig@pengutronix.de
> .
>
> With the above patch applied, enabling the exynos and kirin drivers as
> modules result in a warning about their remove functions that is fixed
> here. The keystone driver is a bit special as it can only be enabled
> built-in and used __refdata on its driver struct. It also had a similar
> issue for .probe fixed in the last patch.
>
> IMHO all four patches qualify for backporting to stable.
I added stable tags and applied to pci/enumeration for v6.7, thanks!
> Uwe Kleine-König (4):
> PCI: exynos: Don't put .remove callback in .exit.text section
> PCI: kirin: Don't put .remove callback in .exit.text section
> PCI: keystone: Don't put .remove callback in .exit.text section
> PCI: keystone: Don't put .probe callback in .init.text section
I updated the subjects to be "Don't discard ... callback" to try to
give a little more semantic context.
> drivers/pci/controller/dwc/pci-exynos.c | 4 ++--
> drivers/pci/controller/dwc/pci-keystone.c | 8 ++++----
> drivers/pci/controller/dwc/pcie-kirin.c | 4 ++--
> 3 files changed, 8 insertions(+), 8 deletions(-)
>
> base-commit: 6465e260f48790807eef06b583b38ca9789b6072
> --
> 2.40.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-10-10 17:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-01 17:02 [PATCH 0/4] pci: Fix some section mismatches Uwe Kleine-König
2023-10-01 17:02 ` [PATCH 1/4] PCI: exynos: Don't put .remove callback in .exit.text section Uwe Kleine-König
2023-10-02 1:38 ` Alim Akhtar
2023-10-01 17:02 ` [PATCH 2/4] PCI: kirin: " Uwe Kleine-König
2023-10-02 22:12 ` Bjorn Helgaas
2023-10-03 10:15 ` Uwe Kleine-König
2023-10-03 20:23 ` Uwe Kleine-König
2023-10-03 20:40 ` Bjorn Helgaas
2023-10-04 8:16 ` Uwe Kleine-König
2023-10-01 17:02 ` [PATCH 3/4] PCI: keystone: " Uwe Kleine-König
2023-10-01 17:02 ` [PATCH 4/4] PCI: keystone: Don't put .probe callback in .init.text section Uwe Kleine-König
2023-10-10 17:23 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231010172346.GA984693@bhelgaas \
--to=helgaas@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=bhelgaas@google.com \
--cc=jingoohan1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kgene.kim@samsung.com \
--cc=kishon@ti.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=m-karicheri2@ti.com \
--cc=mchehab+huawei@kernel.org \
--cc=robh@kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=siva.kallam@samsung.com \
--cc=songxiaowei@hisilicon.com \
--cc=suren.reddy@samsung.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wangbinghui@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).