From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29732CD8CAC for ; Tue, 10 Oct 2023 17:23:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233939AbjJJRX6 (ORCPT ); Tue, 10 Oct 2023 13:23:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233981AbjJJRXw (ORCPT ); Tue, 10 Oct 2023 13:23:52 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC8E5B0; Tue, 10 Oct 2023 10:23:48 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40C44C433C9; Tue, 10 Oct 2023 17:23:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696958628; bh=TSj2de6BZUqT6Q880gh/gtYBmRWs6W7lYgtCRKx6Ag8=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=dgVF2qFuAYixvkDzJvLKt5XD8K4GFyiAmDm2ZEc3BKkL3RkH5qcHfTvxRK/LG81jN bM9CfeltEVlZGI3hG99F05by+x2gAEKJ4lI6bx3MiPjy99ClRQLRwvBZjuuHsnyuQW ZO8BphlSzPRPjNeNtrQqEemhb4/ijt71Rm27icQvXLEp+ASy0IBGcoigGrAP2Y8EL0 AXwQXkkP0kdRHtdTVG3lQ8YOxUjGpjsW++vUaIs5tJBm4pBpeU0Nd0/RdZ+xExnmnZ +9NM6l4Xr8pUI3P9j/COoVhbFNfgVIeJAp3cb02AS40llxdLPqmB6d4zUr7nkLIaeC xqbfGLhhULBOQ== Date: Tue, 10 Oct 2023 12:23:46 -0500 From: Bjorn Helgaas To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Jingoo Han , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Krzysztof Kozlowski , Kukjin Kim , Siva Reddy Kallam , Surendranath Gurivireddy Balla , Xiaowei Song , Binghui Wang , Kishon Vijay Abraham I , Mauro Carvalho Chehab , Santosh Shilimkar , Murali Karicheri , Rob Herring , Alim Akhtar , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 0/4] pci: Fix some section mismatches Message-ID: <20231010172346.GA984693@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231001170254.2506508-1-u.kleine-koenig@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Sun, Oct 01, 2023 at 07:02:50PM +0200, Uwe Kleine-König wrote: > Hello, > > modpost checks about section mismatches are about to get stronger, see > https://lore.kernel.org/linux-kbuild/20230930165204.2478282-1-u.kleine-koenig@pengutronix.de > . > > With the above patch applied, enabling the exynos and kirin drivers as > modules result in a warning about their remove functions that is fixed > here. The keystone driver is a bit special as it can only be enabled > built-in and used __refdata on its driver struct. It also had a similar > issue for .probe fixed in the last patch. > > IMHO all four patches qualify for backporting to stable. I added stable tags and applied to pci/enumeration for v6.7, thanks! > Uwe Kleine-König (4): > PCI: exynos: Don't put .remove callback in .exit.text section > PCI: kirin: Don't put .remove callback in .exit.text section > PCI: keystone: Don't put .remove callback in .exit.text section > PCI: keystone: Don't put .probe callback in .init.text section I updated the subjects to be "Don't discard ... callback" to try to give a little more semantic context. > drivers/pci/controller/dwc/pci-exynos.c | 4 ++-- > drivers/pci/controller/dwc/pci-keystone.c | 8 ++++---- > drivers/pci/controller/dwc/pcie-kirin.c | 4 ++-- > 3 files changed, 8 insertions(+), 8 deletions(-) > > base-commit: 6465e260f48790807eef06b583b38ca9789b6072 > -- > 2.40.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel