Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
	"Hans de Goede" <hdegoede@redhat.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Rafael J . Wysocki" <rjw@rjwysocki.net>,
	"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
	"open list:PCI SUBSYSTEM" <linux-pci@vger.kernel.org>,
	"Kai-Heng Feng" <kai.heng.feng@canonical.com>
Subject: Re: [RFC v1 2/4] PCI: Add support for drivers to decide bridge D3 policy
Date: Sat, 14 Oct 2023 12:53:38 +0200	[thread overview]
Message-ID: <20231014105338.GA3223@wunner.de> (raw)
In-Reply-To: <20231009225653.36030-3-mario.limonciello@amd.com>

On Mon, Oct 09, 2023 at 05:56:51PM -0500, Mario Limonciello wrote:
> commit 9d26d3a8f1b0 ("PCI: Put PCIe ports into D3 during suspend")
> changed pci_bridge_d3_possible() so that any vendor's PCIe ports
> from modern machines (>=2015) are allowed to be put into D3.
> 
> This policy change has worked for most machines, but the behavior
> is improved with `pcie_port_pm=off` on some others.
> 
> Add support for drivers to register a callback that they can optionally
> use to decide the policy on supported machines.

I would assume that drivers can decide the policy already today through
pci_d3cold_enable() / pci_d3cold_disable().

Why is this not sufficient and what's the benefit of the more complex
approach proposed here?

Thanks,

Lukas

  reply	other threads:[~2023-10-14 10:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-09 22:56 [RFC v1 0/4] Add support for drivers to decide bridge D3 policy Mario Limonciello
2023-10-09 22:56 ` [RFC v1 1/4] ACPI: x86: s2idle: Export symbol for fetching constraints for module use Mario Limonciello
2023-10-09 22:56 ` [RFC v1 2/4] PCI: Add support for drivers to decide bridge D3 policy Mario Limonciello
2023-10-14 10:53   ` Lukas Wunner [this message]
2023-10-15 18:55     ` Mario Limonciello
2023-10-09 22:56 ` [RFC v1 3/4] PCI: Check for changes in pci_bridge_d3_possible() when updating D3 Mario Limonciello
2023-10-09 22:56 ` [RFC v1 4/4] platform/x86/amd: pmc: Add support for using constraints to decide D3 policy Mario Limonciello
2023-10-16  2:11   ` Kai-Heng Feng
2023-10-16 21:34     ` Mario Limonciello
2023-10-24  7:05       ` Kai-Heng Feng
2023-10-24 19:45         ` Mario Limonciello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231014105338.GA3223@wunner.de \
    --to=lukas@wunner.de \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=bhelgaas@google.com \
    --cc=hdegoede@redhat.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=kai.heng.feng@canonical.com \
    --cc=linux-pci@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox