From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1541AC41513 for ; Mon, 16 Oct 2023 17:27:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232570AbjJPR1s (ORCPT ); Mon, 16 Oct 2023 13:27:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232295AbjJPR1s (ORCPT ); Mon, 16 Oct 2023 13:27:48 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AC7683; Mon, 16 Oct 2023 10:27:46 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 95FDAC433C8; Mon, 16 Oct 2023 17:27:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697477265; bh=ajYCHCsrrMqPolcWYt4pT2whsLJVivuC6Ws89i9IQ0A=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=DcYluMlIkpFkrE2BZIEpqOz0+cYiWYk3IIG8+Mbtbv0zGcOaPzADEWmvbIJIUmLVk ajqJG6ahGFwgn9NS9whs6EXMKwoq/7+DVg9zdzjhBcRMqydjjOoR5YHWUVNTKzNCw3 MyOhbh63B37a/P/+KIztiqDXCGOxuo3KCwDH4jXCL5tKX5/osZ6plbRVAG6wW6nun7 uwcDewYxw9a+yi40K7mX27E4uhRGKdIvoOY/rMAoYhE7mmimCCQrXznP4evBIXKqev wckow8UDDyqahwYXr2hF2PRN94IUZYA3Zy/LaPwGZKYfHBPwblSNtx11KRFLR0zh0q dGRfP7Qgv5yuw== Date: Mon, 16 Oct 2023 12:27:42 -0500 From: Bjorn Helgaas To: Yoshinori Sato Cc: linux-sh@vger.kernel.org, glaubitz@physik.fu-berlin.de, lpieralisi@kernel.org, kw@linux.com, robh@kernel.org, linux-pci@vger.kernel.org Subject: Re: [RFC PATCH v3 09/35] drivers/pci/controller: SH7751 PCI Host bridge driver. Message-ID: <20231016172742.GA1215127@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org "git am" complained about a couple whitespace errors elsewhere in this series: Applying: arch/sh/boot/compressed/head_32.S: passing FDT address to initialize function. .git/rebase-apply/patch:25: trailing whitespace. Applying: drivers/irqchip: SH7751 IRL external encoder with enable gate. .git/rebase-apply/patch:33: new blank line at EOF. On Sat, Oct 14, 2023 at 11:53:44PM +0900, Yoshinori Sato wrote: > pci-sh7751.h move from "arch/sh/drivers/pci/pci-sh7751.h" > pci-sh7751.c convert from "arch/sh/drivers/pci/pci-sh7751.c" Note the subject line conventions in drivers/pci (use "git log --oneline" to see them): use something like this: PCI: sh7751: Add SH7751 PCI host bridge driver with no period at the end. arch/sh/drivers/pci/pci-sh7751.h and arch/sh/drivers/pci/pci-sh7751.c still exist after applying this series. Better to have a single patch that moves the content from arch/sh/drivers/pci/ to drivers/pci/controller/. Neither file looks like a simple move; there's a lot of reorganization going on at the same time. It's really difficult to review a patch like that because we can't compare the content from before and after. If you make a patch that does the cleanup/reorganization, and a separate patch that is just a simple move, and you use "git mv" for the move, git should notice that this is just a rename, and that diff will be tiny. One of the reorganization patches should be to incorporate the pci-sh7751.h content directly into pci-sh7751.c. Since it's only used in pci-sh7751.c, there's really no advantage to having it in a separate file. Bjorn > Signed-off-by: Yoshinori Sato > --- > drivers/pci/controller/Kconfig | 9 + > drivers/pci/controller/Makefile | 1 + > drivers/pci/controller/pci-sh7751.c | 285 ++++++++++++++++++++++++++++ > drivers/pci/controller/pci-sh7751.h | 267 ++++++++++++++++++++++++++ > 4 files changed, 562 insertions(+) > create mode 100644 drivers/pci/controller/pci-sh7751.c > create mode 100644 drivers/pci/controller/pci-sh7751.h > > diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig > index c0c3f2824990..037ff44bd1e8 100644 > --- a/drivers/pci/controller/Kconfig > +++ b/drivers/pci/controller/Kconfig > @@ -342,6 +342,15 @@ config PCIE_XILINX_CPM > Say 'Y' here if you want kernel support for the > Xilinx Versal CPM host bridge. > > +config PCI_SH7751 > + bool "Renesas SH7751 PCI controller" > + depends on OF > + depends on CPU_SUBTYPE_SH7751 || CPU_SUBTYPE_SH7751R || COMPILE_TEST > + select PCI_HOST_COMMON > + help > + Say 'Y' here if you want kernel to support the Renesas SH7751 PCI > + Host Bridge driver. Move this so the menu entries stay sorted by vendor name. Bjorn