From: kernel test robot <lkp@intel.com>
To: Mario Limonciello <mario.limonciello@amd.com>,
bhelgaas@google.com, mika.westerberg@linux.intel.com
Cc: oe-kbuild-all@lists.linux.dev, andreas.noever@gmail.com,
michael.jamet@intel.com, YehezkelShB@gmail.com,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, Alexander.Deucher@amd.com,
Mario Limonciello <mario.limonciello@amd.com>
Subject: Re: [PATCH 2/2] PCI: Ignore PCIe ports used for tunneling in pcie_bandwidth_available()
Date: Wed, 1 Nov 2023 07:02:58 +0800 [thread overview]
Message-ID: <202311010646.KCczSLIW-lkp@intel.com> (raw)
In-Reply-To: <20231031133438.5299-2-mario.limonciello@amd.com>
Hi Mario,
kernel test robot noticed the following build warnings:
[auto build test WARNING on pci/for-linus]
[also build test WARNING on westeri-thunderbolt/next linus/master v6.6 next-20231031]
[cannot apply to pci/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Mario-Limonciello/PCI-Ignore-PCIe-ports-used-for-tunneling-in-pcie_bandwidth_available/20231031-224221
base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git for-linus
patch link: https://lore.kernel.org/r/20231031133438.5299-2-mario.limonciello%40amd.com
patch subject: [PATCH 2/2] PCI: Ignore PCIe ports used for tunneling in pcie_bandwidth_available()
config: arc-randconfig-002-20231101 (https://download.01.org/0day-ci/archive/20231101/202311010646.KCczSLIW-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231101/202311010646.KCczSLIW-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311010646.KCczSLIW-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/pci/pci.c:6234: warning: Function parameter or member 'pdev' not described in 'pcie_is_tunneling_port'
>> drivers/pci/pci.c:6234: warning: Excess function parameter 'dev' description in 'pcie_is_tunneling_port'
Kconfig warnings: (for reference only)
WARNING: unmet direct dependencies detected for VIDEO_OV7670
Depends on [n]: MEDIA_SUPPORT [=y] && VIDEO_DEV [=y] && VIDEO_CAMERA_SENSOR [=n]
Selected by [y]:
- VIDEO_CAFE_CCIC [=y] && MEDIA_SUPPORT [=y] && MEDIA_PLATFORM_SUPPORT [=y] && MEDIA_PLATFORM_DRIVERS [=y] && V4L_PLATFORM_DRIVERS [=y] && PCI [=y] && I2C [=y] && VIDEO_DEV [=y] && COMMON_CLK [=y]
vim +6234 drivers/pci/pci.c
6225
6226 /**
6227 * pcie_is_tunneling_port - Check if a PCI device is used for TBT3/USB4 tunneling
6228 * @dev: PCI device to check
6229 *
6230 * Returns true if the device is used for PCIe tunneling, false otherwise.
6231 */
6232 static bool
6233 pcie_is_tunneling_port(struct pci_dev *pdev)
> 6234 {
6235 struct device_link *link;
6236 struct pci_dev *supplier;
6237
6238 /* Intel TBT3 bridge */
6239 if (pdev->is_thunderbolt)
6240 return true;
6241
6242 if (!pci_is_pcie(pdev))
6243 return false;
6244
6245 if (pci_pcie_type(pdev) != PCI_EXP_TYPE_ROOT_PORT)
6246 return false;
6247
6248 /* PCIe root port used for tunneling linked to USB4 router */
6249 list_for_each_entry(link, &pdev->dev.links.suppliers, c_node) {
6250 supplier = to_pci_dev(link->supplier);
6251 if (!supplier)
6252 continue;
6253 if (supplier->class == PCI_CLASS_SERIAL_USB_USB4)
6254 return true;
6255 }
6256
6257 return false;
6258 }
6259
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-10-31 23:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 13:34 [PATCH 1/2] PCI: Move the `PCI_CLASS_SERIAL_USB_USB4` definition to common header Mario Limonciello
2023-10-31 13:34 ` [PATCH 2/2] PCI: Ignore PCIe ports used for tunneling in pcie_bandwidth_available() Mario Limonciello
2023-10-31 23:02 ` kernel test robot [this message]
2023-11-01 22:52 ` Bjorn Helgaas
2023-11-02 1:14 ` Mario Limonciello
2023-11-02 10:31 ` Mika Westerberg
2023-11-02 12:07 ` Bjorn Helgaas
2023-11-02 12:17 ` Mika Westerberg
2023-11-02 15:21 ` Lukas Wunner
2023-11-02 15:26 ` Mario Limonciello
2023-11-02 15:33 ` Lukas Wunner
2023-11-02 16:22 ` Mario Limonciello
2023-11-03 5:48 ` Mika Westerberg
2023-11-02 15:47 ` Bjorn Helgaas
2023-11-02 17:28 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202311010646.KCczSLIW-lkp@intel.com \
--to=lkp@intel.com \
--cc=Alexander.Deucher@amd.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=michael.jamet@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).