From: Christoph Hellwig <hch@lst.de>
To: "Petr Tesařík" <petr@tesarici.cz>
Cc: Halil Pasic <pasic@linux.ibm.com>,
Niklas Schnelle <schnelle@linux.ibm.com>,
Christoph Hellwig <hch@lst.de>,
Bjorn Helgaas <bhelgaas@google.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Robin Murphy <robin.murphy@arm.com>,
Petr Tesarik <petr.tesarik1@huawei-partners.com>,
Ross Lagerwall <ross.lagerwall@citrix.com>,
linux-pci <linux-pci@vger.kernel.org>,
linux-kernel@vger.kernel.org, iommu@lists.linux.dev,
Matthew Rosato <mjrosato@linux.ibm.com>
Subject: Re: Memory corruption with CONFIG_SWIOTLB_DYNAMIC=y
Date: Mon, 6 Nov 2023 08:42:43 +0100 [thread overview]
Message-ID: <20231106074243.GA17777@lst.de> (raw)
In-Reply-To: <20231103214831.26d29f4d@meshulam.tesarici.cz>
On Fri, Nov 03, 2023 at 09:50:53PM +0100, Petr Tesařík wrote:
> Seconded. I have also been struggling with the various alignment
> constraints. I have even written (but not yet submitted) a patch to
> calculate the combined alignment mask in swiotlb_tbl_map_single() and
> pass it down to all other functions, just to make it clear what
> alignment mask is used.
That does sound like a good idea.
> My understanding is that buffer alignment may be required by:
>
> 1. hardware which cannot handle an unaligned base address (presumably
> because the chip performs a simple OR operation to get the addresses
> of individual fields);
There's all kinds of weird encodings that discard the low bits.
For NVMe it's the PRPs (that is actually documented in the NVMe
spec, so it might be easiest to grasp), but except for a Mellox
vendor extension this is also how all RDMA memory registrations
work.
next prev parent reply other threads:[~2023-11-06 7:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 15:13 Memory corruption with CONFIG_SWIOTLB_DYNAMIC=y Niklas Schnelle
2023-11-03 16:14 ` Halil Pasic
2023-11-03 20:50 ` Petr Tesařík
2023-11-06 7:42 ` Christoph Hellwig [this message]
2023-11-07 17:24 ` Halil Pasic
2023-11-08 7:30 ` Christoph Hellwig
2023-11-06 10:08 ` Halil Pasic
2023-11-07 17:24 ` Halil Pasic
2023-11-08 9:13 ` Petr Tesařík
2023-11-23 10:16 ` Petr Tesařík
2023-11-27 15:59 ` Christoph Hellwig
2023-11-28 7:16 ` Petr Tesařík
2023-11-03 18:59 ` Petr Tesařík
2023-11-06 7:44 ` Christoph Hellwig
2023-11-06 12:46 ` Petr Tesarik
2023-11-08 10:52 ` Halil Pasic
2023-11-08 11:04 ` Petr Tesarik
2023-11-08 14:32 ` Halil Pasic
2023-11-08 14:45 ` Petr Tesarik
2023-11-10 9:22 ` Halil Pasic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231106074243.GA17777@lst.de \
--to=hch@lst.de \
--cc=bhelgaas@google.com \
--cc=iommu@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mjrosato@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=petr.tesarik1@huawei-partners.com \
--cc=petr@tesarici.cz \
--cc=robin.murphy@arm.com \
--cc=ross.lagerwall@citrix.com \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).