From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE11FC4167D for ; Mon, 6 Nov 2023 16:48:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232864AbjKFQsF (ORCPT ); Mon, 6 Nov 2023 11:48:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232781AbjKFQsE (ORCPT ); Mon, 6 Nov 2023 11:48:04 -0500 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 043D6D49; Mon, 6 Nov 2023 08:48:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1699289282; x=1730825282; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=A4xozrlM98o/6is3EgoMPreQJpmablfWX3/r4GaT1kw=; b=kRFXV4jexd3FZj8ePD1khtpMhGZ9LPkIEnOJz975AOcHLi4Al35E5w0o TcjHaZVaWQHbySKI0rLnxh9mMiATM44vZimXu2RHspU7ayFOd3FetVvQi bjPkqTFb2uz1zrhXmBd0TJLU8C7sYvdnDucYgUNWLLSfKWllAsr3Ti1rE w9w1wO1gO0VogUk2q6bS++gAltfTifay4Z2MMDXEtDqPrwjbeA9qM7xlr Z2P0IDQyktLRaZ+iP4Y86eJVowCDiIsp2BJOVQbWu+bSZWtwdfxilA5RT ig5AkdJnnlF4ClxQ4TipN/EmSJkjgjg8xh39djoPOlTApoo0uqsjpkBb7 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10886"; a="453623285" X-IronPort-AV: E=Sophos;i="6.03,282,1694761200"; d="scan'208";a="453623285" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Nov 2023 08:48:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10886"; a="879501854" X-IronPort-AV: E=Sophos;i="6.03,282,1694761200"; d="scan'208";a="879501854" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga002.fm.intel.com with ESMTP; 06 Nov 2023 08:47:53 -0800 Received: by black.fi.intel.com (Postfix, from userid 1001) id 2F0E31A5; Mon, 6 Nov 2023 18:47:51 +0200 (EET) Date: Mon, 6 Nov 2023 18:47:51 +0200 From: Mika Westerberg To: Ilpo =?utf-8?B?SsOkcnZpbmVu?= Cc: Mario Limonciello , Karol Herbst , Lyude Paul , Alex Deucher , Christian =?utf-8?B?S8O2bmln?= , Bjorn Helgaas , Hans de Goede , Lukas Wunner , Danilo Krummrich , David Airlie , Daniel Vetter , Xinhui Pan , "Rafael J . Wysocki" , Mark Gross , Andreas Noever , Michael Jamet , Yehezkel Bernat , Pali =?utf-8?B?Um9ow6Fy?= , Marek =?utf-8?B?QmVow7pu?= , "Maciej W . Rozycki" , Manivannan Sadhasivam , "open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS" , "open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS" , open list , "open list:RADEON and AMDGPU DRM DRIVERS" , "open list:PCI SUBSYSTEM" , "open list:ACPI" , "open list:X86 PLATFORM DRIVERS" , "open list:THUNDERBOLT DRIVER" Subject: Re: [PATCH v2 1/9] drm/nouveau: Switch from pci_is_thunderbolt_attached() to dev_is_removable() Message-ID: <20231106164751.GS17433@black.fi.intel.com> References: <20231103190758.82911-1-mario.limonciello@amd.com> <20231103190758.82911-2-mario.limonciello@amd.com> <55563d57-60c3-1789-1e7c-5e618fbd6253@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <55563d57-60c3-1789-1e7c-5e618fbd6253@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, Nov 06, 2023 at 02:25:24PM +0200, Ilpo Järvinen wrote: > On Fri, 3 Nov 2023, Mario Limonciello wrote: > > > pci_is_thunderbolt_attached() only works for Intel TBT devices. Switch to > > using dev_is_removable() to be able to detect USB4 devices as well. > > Please extend this with more details. I had to lookup the TBT change to > be able to make any guess why you're doing this (and it's still a guess > at best). Also please write it as Thunderbolt not TBT so that it is clear what we are talking about. Ditto to all patches.