Re: [PATCH v7 2/3] PCI: brcmstb: Configure HW CLKREQ# mode appropriate for downstream device

[Bjorn Helgaas <helgaas@kernel.org>]

On Fri, Nov 10, 2023 at 08:01:23AM -0500, Jim Quinlan wrote:
> On Thu, Nov 9, 2023 at 5:31 PM Bjorn Helgaas <helgaas@kernel.org> wrote:
> >
> > On Thu, Nov 09, 2023 at 05:06:15PM -0500, Jim Quinlan wrote:
> > > ...
> >
> > > BTW, besides the RPi4, I haven't been able to find a Linux platform
> > > where I can do
> > >
> > >         echo $POLICY > /sys/module/pcie_aspm/parameters/policy
> >
> > This sounds like something we should fix.  What exactly happens?  I
> > think this should be handled at pcie_aspm_set_policy(), so:
> 
> Well, I've tried changing the ASPM policy on my x86 Ubuntu system
> and IIRC a Fedora system.  In both cases it says "illegal write
> operation" but I am root and the "policy" file does have rw perms
> for root, so I have no idea how it comes back with that error.  Some
> machines allow one to change the setting in the BIOS, FWIW.

BIOS settings like that are potentially misleading unless the BIOS
*also* retains ownership of ASPM or changes the ASPM features
advertised by devices.  If BIOS grants ASPM ownership to the OS, BIOS
should not assume anything about how the OS will configure ASPM.

> Right now on my CM4, "echo $POLICY  > policy" actually works.
> Perhaps when I was testing this I did not yet apply my commits, or
> perhaps it was with a specific endpoint device.  Regardless, I'll
> let you know with a backtrace if I see this again.

Great, thanks!

Bjorn