From: Bjorn Helgaas <helgaas@kernel.org>
To: Daniel Stodden <dns@arista.com>
Cc: Dmitry Safonov <dima@arista.com>,
Kurt Schwemmer <kurt.schwemmer@microsemi.com>,
Logan Gunthorpe <logang@deltatee.com>,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v3] switchtec: Fix stdev_release crash after suprise device loss.
Date: Tue, 21 Nov 2023 18:39:41 -0600 [thread overview]
Message-ID: <20231122003941.GA265415@bhelgaas> (raw)
In-Reply-To: <581038D0-C2B6-431C-BC67-5DDE9458FACA@arista.com>
On Tue, Nov 21, 2023 at 04:02:12PM -0800, Daniel Stodden wrote:
> > On Nov 21, 2023, at 3:58 PM, Daniel Stodden <dns@arista.com> wrote:
> >
> > + put_device(&stdev->pdev);
>
> That was just a sketch. Actuall pci_dev_put.
Can you clarify what I should do with this? The current commit log
reads like this:
A PCI device hot removal may occur while stdev->cdev is held open. The call
to stdev_release() then happens during close or exit, at a point way past
switchtec_pci_remove(). Otherwise the last ref would vanish with the
trailing put_device(), just before return.
Are you saying it needs a change?
Bjorn
next prev parent reply other threads:[~2023-11-22 0:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 21:21 [PATCH v3 0/1] switchtec: Fix stdev_release crash after suprise device loss Daniel Stodden
2023-11-13 21:21 ` [PATCH v3] " Daniel Stodden
2023-11-20 21:25 ` Bjorn Helgaas
2023-11-21 18:23 ` Daniel Stodden
2023-11-21 18:40 ` Bjorn Helgaas
2023-11-21 23:58 ` Daniel Stodden
2023-11-22 0:02 ` Daniel Stodden
2023-11-22 0:39 ` Bjorn Helgaas [this message]
2023-11-22 0:19 ` Bjorn Helgaas
2023-11-22 0:25 ` Dmitry Safonov
2023-11-22 0:37 ` Bjorn Helgaas
2023-11-22 0:37 ` Dmitry Safonov
2023-11-22 0:41 ` Bjorn Helgaas
2023-11-22 1:02 ` Daniel Stodden
2023-11-22 3:16 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231122003941.GA265415@bhelgaas \
--to=helgaas@kernel.org \
--cc=dima@arista.com \
--cc=dns@arista.com \
--cc=kurt.schwemmer@microsemi.com \
--cc=linux-pci@vger.kernel.org \
--cc=logang@deltatee.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox