linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johan Hovold <johan+linaro@kernel.org>
To: "Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Krzysztof Wilczyński" <kw@linux.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>
Cc: Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Nirmal Patel <nirmal.patel@linux.intel.com>,
	Jonathan Derrick <jonathan.derrick@linux.dev>,
	linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Johan Hovold <johan+linaro@kernel.org>,
	stable@vger.kernel.org,
	Michael Bottini <michael.a.bottini@linux.intel.com>,
	"David E . Box" <david.e.box@linux.intel.com>,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: [PATCH v2 2/6] PCI: vmd: Fix deadlock when enabling ASPM
Date: Tue, 28 Nov 2023 09:15:08 +0100	[thread overview]
Message-ID: <20231128081512.19387-3-johan+linaro@kernel.org> (raw)
In-Reply-To: <20231128081512.19387-1-johan+linaro@kernel.org>

The vmd_pm_enable_quirk() helper is called from pci_walk_bus() during
probe to enable ASPM for controllers with VMD_FEAT_BIOS_PM_QUIRK set.

Since pci_walk_bus() already holds a pci_bus_sem read lock, use the new
locked helper to enable link states in order to avoid a potential
deadlock (e.g. in case someone takes a write lock before reacquiring
the read lock).

Fixes: f492edb40b54 ("PCI: vmd: Add quirk to configure PCIe ASPM and LTR")
Cc: stable@vger.kernel.org      # 6.3
Cc: Michael Bottini <michael.a.bottini@linux.intel.com>
Cc: David E. Box <david.e.box@linux.intel.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 drivers/pci/controller/vmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c
index 94ba61fe1c44..0452cbc362ee 100644
--- a/drivers/pci/controller/vmd.c
+++ b/drivers/pci/controller/vmd.c
@@ -751,7 +751,7 @@ static int vmd_pm_enable_quirk(struct pci_dev *pdev, void *userdata)
 	if (!(features & VMD_FEAT_BIOS_PM_QUIRK))
 		return 0;
 
-	pci_enable_link_state(pdev, PCIE_LINK_STATE_ALL);
+	pci_enable_link_state_locked(pdev, PCIE_LINK_STATE_ALL);
 
 	pos = pci_find_ext_capability(pdev, PCI_EXT_CAP_ID_LTR);
 	if (!pos)
-- 
2.41.0


  parent reply	other threads:[~2023-11-28  8:15 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-28  8:15 [PATCH v2 0/6] PCI: Fix deadlocks when enabling ASPM Johan Hovold
2023-11-28  8:15 ` [PATCH v2 1/6] PCI/ASPM: Add locked helper for enabling link state Johan Hovold
2023-12-07 20:47   ` Bjorn Helgaas
2023-12-08  8:00     ` Johan Hovold
2023-12-08 17:39       ` Bjorn Helgaas
2023-12-12  9:25         ` Ilpo Järvinen
2023-12-12  3:48     ` Kai-Heng Feng
2023-12-12 21:27       ` Bjorn Helgaas
2023-12-13 19:48         ` David E. Box
2023-12-13 20:45           ` Bjorn Helgaas
2023-12-13 23:39             ` David E. Box
2023-12-14 17:28               ` Bjorn Helgaas
2023-11-28  8:15 ` Johan Hovold [this message]
2023-11-28  8:15 ` [PATCH v2 3/6] PCI: qcom: Fix deadlock when enabling ASPM Johan Hovold
2023-11-28  8:15 ` [PATCH v2 4/6] PCI: qcom: Clean up ASPM comment Johan Hovold
2023-11-28  8:15 ` [PATCH v2 5/6] PCI/ASPM: Clean up disable link state parameter Johan Hovold
2023-11-28  8:15 ` [PATCH v2 6/6] PCI/ASPM: Add lockdep assert to link state helper Johan Hovold
2023-12-07 13:25 ` [PATCH v2 0/6] PCI: Fix deadlocks when enabling ASPM Johan Hovold
2023-12-10 12:35   ` Linux regression tracking #update (Thorsten Leemhuis)
2023-12-08 17:53 ` Bjorn Helgaas
2023-12-11 17:35   ` Johan Hovold
2023-12-11 18:11     ` Bjorn Helgaas
2023-12-11 20:13       ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231128081512.19387-3-johan+linaro@kernel.org \
    --to=johan+linaro@kernel.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=david.e.box@linux.intel.com \
    --cc=jonathan.derrick@linux.dev \
    --cc=konrad.dybcio@linaro.org \
    --cc=kw@linux.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=michael.a.bottini@linux.intel.com \
    --cc=nirmal.patel@linux.intel.com \
    --cc=robh@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).