linux-pci.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Herve Codina <herve.codina@bootlin.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Lizhi Hou <lizhi.hou@amd.com>, Max Zhen <max.zhen@amd.com>,
	Sonal Santan <sonal.santan@amd.com>,
	Stefano Stabellini <stefano.stabellini@xilinx.com>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	PCI <linux-pci@vger.kernel.org>,
	Allan Nielsen <allan.nielsen@microchip.com>,
	Horatiu Vultur <horatiu.vultur@microchip.com>,
	Steen Hegelund <steen.hegelund@microchip.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v2 0/2] Attach DT nodes to existing PCI devices
Date: Fri, 1 Dec 2023 16:45:56 -0600	[thread overview]
Message-ID: <20231201224556.GA534342@bhelgaas> (raw)
In-Reply-To: <CAL_JsqJvt6FpXK+FgAwE8xN3G5Z23Ktq=SEY-K7VA7nM5XgZRg@mail.gmail.com>

On Fri, Dec 01, 2023 at 04:26:45PM -0600, Rob Herring wrote:
> On Thu, Nov 30, 2023 at 10:57 AM Herve Codina <herve.codina@bootlin.com> wrote:
> ...

> Also, no idea if the bridge part works because my qemu setup doesn't
> create bridges (anyone got a magic cmdline to create them?).

I probably copied this from somewhere and certainly couldn't construct
it from scratch, but it did create a hierarchy like this:

  00:04.0 bridge to [bus 01-04] (Root Port)
  01:00.0 bridge to [bus 02-04] (Switch Upstream Port)
  02:00.0 bridge to [bus 03] (Switch Downstream Port)
  02:01.0 bridge to [bus 04] (Switch Downstream Port)
  03:00.0 endpoint
  04:00.0 endpoint

  IMAGE=ubuntu.img
  KERNEL=~/linux/arch/x86/boot/bzImage
  IMGDIR=~/virt/img/

  qemu-system-x86_64 -enable-kvm -s -m 2048 $IMAGE \
      -device pcie-root-port,id=root_port1,chassis=1,slot=1 \
      -device x3130-upstream,id=upstream_port1,bus=root_port1 \
      -device xio3130-downstream,id=downstream_port1,bus=upstream_port1,chassis=2,slot=1 \
      -device xio3130-downstream,id=downstream_port2,bus=upstream_port1,chassis=2,slot=2 \
      -drive file=${IMGDIR}/nvme.qcow2,if=none,id=nvme1,snapshot=on \
      -device nvme,drive=nvme1,serial=nvme1,cmb_size_mb=2048,bus=downstream_port1 \
      -drive file=${IMGDIR}/nvme2.qcow2,if=none,id=nvme2,snapshot=on \
      -device nvme,drive=nvme2,serial=nvme1,bus=downstream_port2 \
      -virtfs local,id=home,path=/home/,security_model=mapped,mount_tag=home \
      -nographic \
      -kernel $KERNEL \
      -append "root=/dev/sda2 rootfstype=ext4 console=ttyS0,38400n8"

  reply	other threads:[~2023-12-01 22:45 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-30 16:56 [PATCH v2 0/2] Attach DT nodes to existing PCI devices Herve Codina
2023-11-30 16:56 ` [PATCH v2 1/2] driver core: Introduce device_{add,remove}_of_node() Herve Codina
2023-11-30 16:56 ` [PATCH v2 2/2] PCI: of: Attach created of_node to existing device Herve Codina
2023-12-01 22:49   ` Bjorn Helgaas
2023-12-01 22:26 ` [PATCH v2 0/2] Attach DT nodes to existing PCI devices Rob Herring
2023-12-01 22:45   ` Bjorn Helgaas [this message]
2023-12-04 16:48     ` Lizhi Hou
2023-12-04 12:43   ` Herve Codina
2023-12-04 13:59     ` Rob Herring
2023-12-04 15:30       ` Herve Codina
2023-12-04 23:03         ` Rob Herring
2023-12-05  8:04           ` Herve Codina
2023-12-07 22:51             ` Rob Herring
2023-12-08  8:48               ` Herve Codina
2023-12-14 14:31                 ` Herve Codina
2024-03-19 14:41                   ` Herve Codina
2023-12-05 18:53           ` Lizhi Hou
2023-12-15 13:52       ` Herve Codina
2024-03-19 15:25         ` Bjorn Helgaas
2024-03-19 16:34           ` Herve Codina
2024-03-19 16:54             ` Bjorn Helgaas
2024-04-10 21:41             ` Rob Herring
2024-04-11 14:05               ` Herve Codina
2024-04-11 20:57                 ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231201224556.GA534342@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=allan.nielsen@microchip.com \
    --cc=bhelgaas@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=herve.codina@bootlin.com \
    --cc=horatiu.vultur@microchip.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lizhi.hou@amd.com \
    --cc=max.zhen@amd.com \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=sonal.santan@amd.com \
    --cc=steen.hegelund@microchip.com \
    --cc=stefano.stabellini@xilinx.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).