From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A007E19A4; Fri, 8 Dec 2023 06:39:00 -0800 (PST) Received: from mail.maildlp.com (unknown [172.18.186.231]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4Smv0G6ChVz6K5rY; Fri, 8 Dec 2023 22:38:54 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id A92FB140680; Fri, 8 Dec 2023 22:38:58 +0800 (CST) Received: from localhost (10.126.175.81) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 8 Dec 2023 14:38:58 +0000 Date: Fri, 8 Dec 2023 14:38:57 +0000 From: Jonathan Cameron To: Bjorn Helgaas CC: , Mahesh J Salgaonkar , Oliver O'Halloran , Robert Richter , Terry Bowman , Kai-Heng Feng , , , Bjorn Helgaas Subject: Re: [PATCH 3/3] PCI/AER: Use explicit register sizes for struct members Message-ID: <20231208143857.000061f4@Huawei.com> In-Reply-To: <20231206224231.732765-4-helgaas@kernel.org> References: <20231206224231.732765-1-helgaas@kernel.org> <20231206224231.732765-4-helgaas@kernel.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: lhrpeml100005.china.huawei.com (7.191.160.25) To lhrpeml500005.china.huawei.com (7.191.163.240) On Wed, 6 Dec 2023 16:42:31 -0600 Bjorn Helgaas wrote: > From: Bjorn Helgaas > > aer_irq() reads the AER Root Error Status and Error Source Identification > (PCI_ERR_ROOT_STATUS and PCI_ERR_ROOT_ERR_SRC) registers directly into > struct aer_err_source. Both registers are 32 bits, so declare the members > explicitly as "u32" instead of "unsigned int". > > Similarly, aer_get_device_error_info() reads the AER Header Log > (PCI_ERR_HEADER_LOG) registers, which are also 32 bits, into struct > aer_header_log_regs. Declare those members as "u32" as well. > > No functional changes intended. > > Signed-off-by: Bjorn Helgaas Another sensible cleanup. FWIW on such simple patches Reviewed-by: Jonathan Cameron