From: Bjorn Helgaas <helgaas@kernel.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Martin Mares <mj@ucw.cz>,
linux-pci@vger.kernel.org,
Gustavo Pimentel <Gustavo.Pimentel@synopsys.com>
Subject: Re: [PATCH v2 1/1] lspci: Add PCIe 6.0 data rate (64 GT/s) also to LnkCap2
Date: Fri, 8 Dec 2023 10:59:00 -0600 [thread overview]
Message-ID: <20231208165900.GA797060@bhelgaas> (raw)
In-Reply-To: <20231208101307.2566-1-ilpo.jarvinen@linux.intel.com>
[+cc Gustavo (author of 5bdf63b6b1bc), just FYI in case you're
interested in picking up this change for your use]
On Fri, Dec 08, 2023 at 12:13:07PM +0200, Ilpo Järvinen wrote:
> While commit 5bdf63b6b1bc ("lspci: Add PCIe 6.0 data rate (64 GT/s)
> support") added 64 GT/s support to some registers, LnkCap2 Supported
> Link Speeds Vector was not included.
>
> Add PCIe 6.0 data rate bit check also into
> cap_express_link2_speed_cap().
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
>
> v2:
> - Corrected the commit hash in the changelog
>
> ls-caps.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/ls-caps.c b/ls-caps.c
> index fce9502bd29a..2c99812c4ed2 100644
> --- a/ls-caps.c
> +++ b/ls-caps.c
> @@ -1191,8 +1191,10 @@ static const char *cap_express_link2_speed_cap(int vector)
> * permitted to skip support for any data rates between 2.5GT/s and the
> * highest supported rate.
> */
> - if (vector & 0x60)
> + if (vector & 0x40)
> return "RsvdP";
> + if (vector & 0x20)
> + return "2.5-64GT/s";
> if (vector & 0x10)
> return "2.5-32GT/s";
> if (vector & 0x08)
> --
> 2.30.2
>
prev parent reply other threads:[~2023-12-08 16:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-08 10:13 [PATCH v2 1/1] lspci: Add PCIe 6.0 data rate (64 GT/s) also to LnkCap2 Ilpo Järvinen
2023-12-08 15:09 ` Martin Mareš
2023-12-08 16:59 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231208165900.GA797060@bhelgaas \
--to=helgaas@kernel.org \
--cc=Gustavo.Pimentel@synopsys.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=mj@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).