[PATCH v2 1/1] lspci: Add PCIe 6.0 data rate (64 GT/s) also to LnkCap2

[PATCH v2 1/1] lspci: Add PCIe 6.0 data rate (64 GT/s) also to LnkCap2

[Ilpo Järvinen]

While commit 5bdf63b6b1bc ("lspci: Add PCIe 6.0 data rate (64 GT/s)
support") added 64 GT/s support to some registers, LnkCap2 Supported
Link Speeds Vector was not included.

Add PCIe 6.0 data rate bit check also into
cap_express_link2_speed_cap().

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---

v2:
- Corrected the commit hash in the changelog

 ls-caps.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/ls-caps.c b/ls-caps.c
index fce9502bd29a..2c99812c4ed2 100644
--- a/ls-caps.c
+++ b/ls-caps.c
@@ -1191,8 +1191,10 @@ static const char *cap_express_link2_speed_cap(int vector)
    * permitted to skip support for any data rates between 2.5GT/s and the
    * highest supported rate.
    */
-  if (vector & 0x60)
+  if (vector & 0x40)
     return "RsvdP";
+  if (vector & 0x20)
+    return "2.5-64GT/s";
   if (vector & 0x10)
     return "2.5-32GT/s";
   if (vector & 0x08)
-- 
2.30.2

Re: [PATCH v2 1/1] lspci: Add PCIe 6.0 data rate (64 GT/s) also to LnkCap2

[Martin Mareš]

Hello!

> While commit 5bdf63b6b1bc ("lspci: Add PCIe 6.0 data rate (64 GT/s)
> support") added 64 GT/s support to some registers, LnkCap2 Supported
> Link Speeds Vector was not included.
> 
> Add PCIe 6.0 data rate bit check also into
> cap_express_link2_speed_cap().
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Thanks, applied.

				Have a nice fortnight
-- 
Martin `MJ' Mareš                        <mj@ucw.cz>   http://mj.ucw.cz/
United Computer Wizards, Prague, Czech Republic, Europe, Earth, Universe

Re: [PATCH v2 1/1] lspci: Add PCIe 6.0 data rate (64 GT/s) also to LnkCap2

[Bjorn Helgaas]

[+cc Gustavo (author of 5bdf63b6b1bc), just FYI in case you're
interested in picking up this change for your use]

On Fri, Dec 08, 2023 at 12:13:07PM +0200, Ilpo Järvinen wrote:
> While commit 5bdf63b6b1bc ("lspci: Add PCIe 6.0 data rate (64 GT/s)
> support") added 64 GT/s support to some registers, LnkCap2 Supported
> Link Speeds Vector was not included.
> 
> Add PCIe 6.0 data rate bit check also into
> cap_express_link2_speed_cap().
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> ---
> 
> v2:
> - Corrected the commit hash in the changelog
> 
>  ls-caps.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/ls-caps.c b/ls-caps.c
> index fce9502bd29a..2c99812c4ed2 100644
> --- a/ls-caps.c
> +++ b/ls-caps.c
> @@ -1191,8 +1191,10 @@ static const char *cap_express_link2_speed_cap(int vector)
>     * permitted to skip support for any data rates between 2.5GT/s and the
>     * highest supported rate.
>     */
> -  if (vector & 0x60)
> +  if (vector & 0x40)
>      return "RsvdP";
> +  if (vector & 0x20)
> +    return "2.5-64GT/s";
>    if (vector & 0x10)
>      return "2.5-32GT/s";
>    if (vector & 0x08)
> -- 
> 2.30.2
>