From: Ethan Zhao <haifeng.zhao@linux.intel.com>
To: bhelgaas@google.com, baolu.lu@linux.intel.com,
dwmw2@infradead.org, will@kernel.org, robin.murphy@arm.com,
lukas@wunner.de
Cc: linux-pci@vger.kernel.org, iommu@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: [RFC PATCH v6 4/4] iommu/vt-d: break out devTLB invalidation if target device is gone
Date: Sun, 24 Dec 2023 00:06:57 -0500 [thread overview]
Message-ID: <20231224050657.182022-5-haifeng.zhao@linux.intel.com> (raw)
In-Reply-To: <20231224050657.182022-1-haifeng.zhao@linux.intel.com>
to fix the rare case, the in-process safe_removal unpluged device could
be supprise_removed anytime, thus check the target device state if it
is gone, don't wait for the completion/timeout anymore. it might cause
hard lockup or system hang
Signed-off-by: Ethan Zhao <haifeng.zhao@linux.intel.com>
---
drivers/iommu/intel/dmar.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/iommu/intel/dmar.c b/drivers/iommu/intel/dmar.c
index 23cb80d62a9a..7a273ee80c49 100644
--- a/drivers/iommu/intel/dmar.c
+++ b/drivers/iommu/intel/dmar.c
@@ -1423,6 +1423,13 @@ int qi_submit_sync(struct intel_iommu *iommu, struct qi_desc *desc,
writel(qi->free_head << shift, iommu->reg + DMAR_IQT_REG);
while (qi->desc_status[wait_index] != QI_DONE) {
+ /*
+ * if the devTLB invalidation target device is gone, don't wait
+ * anymore, it might take up to 1min+50%, causes system hang.
+ */
+ if (type == QI_DIOTLB_TYPE && iommu->flush_target_dev)
+ if (!pci_device_is_present(to_pci_dev(iommu->flush_target_dev)))
+ break;
/*
* We will leave the interrupts disabled, to prevent interrupt
* context to queue another cmd while a cmd is already submitted
--
2.31.1
next prev parent reply other threads:[~2023-12-24 5:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-24 5:06 [RFC PATCH v6 0/4] fix vt-d hard lockup when hotplug ATS capable device Ethan Zhao
2023-12-24 5:06 ` [RFC PATCH v6 1/4] PCI: make pci_dev_is_disconnected() helper public for other drivers Ethan Zhao
2023-12-24 5:06 ` [RFC PATCH v6 2/4] iommu/vt-d: don's issue devTLB flush request when device is disconnected Ethan Zhao
2023-12-24 10:32 ` Lukas Wunner
2023-12-25 1:00 ` Ethan Zhao
2023-12-25 1:56 ` Ethan Zhao
2023-12-24 22:43 ` Bjorn Helgaas
2023-12-25 1:19 ` Ethan Zhao
2023-12-25 1:46 ` Ethan Zhao
2023-12-25 2:21 ` Bjorn Helgaas
2023-12-25 2:35 ` Ethan Zhao
2023-12-25 9:12 ` Ethan Zhao
2023-12-27 2:40 ` Ethan Zhao
2023-12-24 5:06 ` [RFC PATCH v6 3/4] iommu/vt-d: add flush_target_dev member to struct intel_iommu and pass device info to all needed functions Ethan Zhao
2023-12-24 5:06 ` Ethan Zhao [this message]
2023-12-24 10:47 ` [RFC PATCH v6 4/4] iommu/vt-d: break out devTLB invalidation if target device is gone Lukas Wunner
2023-12-25 1:16 ` Ethan Zhao
2023-12-25 8:57 ` Ethan Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231224050657.182022-5-haifeng.zhao@linux.intel.com \
--to=haifeng.zhao@linux.intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox