From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 647D11E497 for ; Mon, 25 Dec 2023 20:37:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="OXmuJEIf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1703536648; x=1735072648; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=q1mIITEft+t9JsoofwE77gF4Vd8IZinqlK4yVXS5Tro=; b=OXmuJEIf2JoVN3WZr5oYyV4ZNPiQOv7/Ha3bdAPB2OC502Hs3oMd8WM/ c7RXa3zORSfRAlsGgPQ9pcVs/3nQNGvKJHvoB9CcouGY7naGF9AKswNcs sGVjPUT1ERJm0IpohBGP7PtqmA8/NDyjhfWGdak/BAp2zL2Sh5XgI966W +PCES3drF32045scJaWmD/xyTJSVMXSwt501pnZtuKJdihj7ilB4RBS2u o4qCYjEXiwy/dqVIxYVNpyuXTnGLctZglgcNi8G1o2QfiARFbztUlQZNO C1BtMVkgZR/ykrj4nMsGpOk7+gganUbMt+B6sUB/3F9T5pBr8jAOQL7gn w==; X-IronPort-AV: E=McAfee;i="6600,9927,10934"; a="14982715" X-IronPort-AV: E=Sophos;i="6.04,304,1695711600"; d="scan'208";a="14982715" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Dec 2023 12:37:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10934"; a="951047368" X-IronPort-AV: E=Sophos;i="6.04,304,1695711600"; d="scan'208";a="951047368" Received: from lkp-server02.sh.intel.com (HELO b07ab15da5fe) ([10.239.97.151]) by orsmga005.jf.intel.com with ESMTP; 25 Dec 2023 12:37:25 -0800 Received: from kbuild by b07ab15da5fe with local (Exim 4.96) (envelope-from ) id 1rHrgL-000DfV-1F; Mon, 25 Dec 2023 20:36:38 +0000 Date: Tue, 26 Dec 2023 04:36:08 +0800 From: kernel test robot To: Matthew W Carlis , helgaas@kernel.org, bhelgaas@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, linux-pci@vger.kernel.org, mika.westerberg@linux.intel.com Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Matthew W Carlis Subject: Re: [PATCH 1/1] PCI/portdrv: Allow DPC if the OS controls AER natively. Message-ID: <202312260431.ZXppQZ1I-lkp@intel.com> References: <20231223212235.34293-2-mattc@purestorage.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231223212235.34293-2-mattc@purestorage.com> Hi Matthew, kernel test robot noticed the following build errors: [auto build test ERROR on pci/next] [also build test ERROR on pci/for-linus linus/master v6.7-rc7 next-20231222] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Matthew-W-Carlis/PCI-portdrv-Allow-DPC-if-the-OS-controls-AER-natively/20231225-154046 base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next patch link: https://lore.kernel.org/r/20231223212235.34293-2-mattc%40purestorage.com patch subject: [PATCH 1/1] PCI/portdrv: Allow DPC if the OS controls AER natively. config: arm-defconfig (https://download.01.org/0day-ci/archive/20231226/202312260431.ZXppQZ1I-lkp@intel.com/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231226/202312260431.ZXppQZ1I-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202312260431.ZXppQZ1I-lkp@intel.com/ All errors (new ones prefixed by >>): >> drivers/pci/pcie/portdrv.c:272:12: error: no member named 'aer_cap' in 'struct pci_dev'; did you mean 'acs_cap'? (dev->aer_cap && host->native_aer))) ^~~~~~~ acs_cap include/linux/pci.h:519:7: note: 'acs_cap' declared here u16 acs_cap; /* ACS Capability offset */ ^ 1 error generated. vim +272 drivers/pci/pcie/portdrv.c 244 245 /* Root Ports and Root Complex Event Collectors may generate PMEs */ 246 if ((pci_pcie_type(dev) == PCI_EXP_TYPE_ROOT_PORT || 247 pci_pcie_type(dev) == PCI_EXP_TYPE_RC_EC) && 248 (pcie_ports_native || host->native_pme)) { 249 services |= PCIE_PORT_SERVICE_PME; 250 251 /* 252 * Disable PME interrupt on this port in case it's been enabled 253 * by the BIOS (the PME service driver will enable it when 254 * necessary). 255 */ 256 pcie_pme_interrupt_enable(dev, false); 257 } 258 259 /* 260 * _OSC AER Control is required by the OS & requires OS to control AER, 261 * but _OSC DPC Control isn't required by the OS to control DPC; however 262 * it does require the OS to control DPC. _OSC DPC Control also requres 263 * _OSC EDR Control (Error Disconnect Recovery) (PCI Firmware - DPC ECN rev3.2) 264 * PCI_Express_Base 6.1, 6.2.11 Determination of DPC Control recommends 265 * platform fw or OS always link control of DPC to AER. 266 * 267 * With dpc-native, allow Linux to use DPC even if it doesn't have 268 * permission to use AER. 269 */ 270 if (pci_find_ext_capability(dev, PCI_EXT_CAP_ID_DPC) && 271 pci_aer_available() && (pcie_ports_dpc_native || > 272 (dev->aer_cap && host->native_aer))) 273 services |= PCIE_PORT_SERVICE_DPC; 274 275 if (pci_pcie_type(dev) == PCI_EXP_TYPE_DOWNSTREAM || 276 pci_pcie_type(dev) == PCI_EXP_TYPE_ROOT_PORT) { 277 u32 linkcap; 278 279 pcie_capability_read_dword(dev, PCI_EXP_LNKCAP, &linkcap); 280 if (linkcap & PCI_EXP_LNKCAP_LBNC) 281 services |= PCIE_PORT_SERVICE_BWNOTIF; 282 } 283 284 return services; 285 } 286 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki