Re: [RFC 3/9] PCI/portdrv: create platform devices for child OF nodes

Lukas Wunner
2024-01-09T14:43:35Z

On Thu, Jan 04, 2024 at 02:01:17PM +0100, Bartosz Golaszewski wrote:
> In order to introduce PCIe power-sequencing, we need to create platform
> devices for child nodes of the port driver node. They will get matched
> against the pwrseq drivers (if one exists) and then the actuak PCIe
> device will reuse the node once it's detected on the bus.
[...]
> --- a/drivers/pci/pcie/portdrv.c
> +++ b/drivers/pci/pcie/portdrv.c
> @@ -715,7 +716,7 @@ static int pcie_portdrv_probe(struct pci_dev *dev,
> pm_runtime_allow(&dev->dev);
> }
>
> - return 0;
> + return devm_of_platform_populate(&dev->dev);
> }

I think this belongs in of_pci_make_dev_node(), portdrv seems totally
the wrong place. Note that you're currently calling this for RCECs
(Root Complex Event Collectors) as well, which is likely not what
you want.

devm functions can't be used in the PCI core, so symmetrically call
of_platform_unpopulate() from of_pci_remove_node().

Thanks,

Lukas