Re: [RFC 3/9] PCI/portdrv: create platform devices for child OF nodes

Jeff Johnson
2024-01-06T01:07:30Z

On 1/4/2024 5:01 AM, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> In order to introduce PCIe power-sequencing, we need to create platform
> devices for child nodes of the port driver node. They will get matched
> against the pwrseq drivers (if one exists) and then the actuak PCIe

nit if you re-spin: s/actuak /actual /

> device will reuse the node once it's detected on the bus.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
> drivers/pci/pcie/portdrv.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/pcie/portdrv.c b/drivers/pci/pcie/portdrv.c
> index 14a4b89a3b83..401fb731009d 100644
> --- a/drivers/pci/pcie/portdrv.c
> +++ b/drivers/pci/pcie/portdrv.c
> @@ -13,6 +13,7 @@
> #include <linux/pci.h>
> #include <linux/kernel.h>
> #include <linux/errno.h>
> +#include <linux/of_platform.h>
> #include <linux/pm.h>
> #include <linux/pm_runtime.h>
> #include <linux/string.h>
> @@ -715,7 +716,7 @@ static int pcie_portdrv_probe(struct pci_dev *dev,
> pm_runtime_allow(&dev->dev);
> }
>
> - return 0;
> + return devm_of_platform_populate(&dev->dev);
> }
>
> static void pcie_portdrv_remove(struct pci_dev *dev)