Re: [PATCH v7 13/16] PCI: imx6: Clean up get addr_space code

Manivannan Sadhasivam
2024-01-07T05:55:20Z

On Wed, Dec 27, 2023 at 01:27:24PM -0500, Frank Li wrote:

Subject: PCI: imx6: Rely on DWC core to fetch 'addr_space' region

> The common dw_pcie_ep_init() already do the same thing. Needn't platform
> driver do it again.
>

'Since the dw_pcie_ep_init() function is already fetching the 'addr_space'
region, no need to do the same in this driver.'

> Signed-off-by: Frank Li <Frank.Li@nxp.com>

With above changes,

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

- Mani

> ---
>
> Notes:
> Change from v1 to v3
> - new patches
>
> drivers/pci/controller/dwc/pci-imx6.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
> index 9e60ab6f1885a..4b2b9aafad1b4 100644
> --- a/drivers/pci/controller/dwc/pci-imx6.c
> +++ b/drivers/pci/controller/dwc/pci-imx6.c
> @@ -1080,7 +1080,6 @@ static int imx6_add_pcie_ep(struct imx6_pcie *imx6_pcie,
> int ret;
> unsigned int pcie_dbi2_offset;
> struct dw_pcie_ep *ep;
> - struct resource *res;
> struct dw_pcie *pci = imx6_pcie->pci;
> struct dw_pcie_rp *pp = &pci->pp;
> struct device *dev = pci->dev;
> @@ -1099,14 +1098,8 @@ static int imx6_add_pcie_ep(struct imx6_pcie *imx6_pcie,
> pcie_dbi2_offset = SZ_4K;
> break;
> }
> - pci->dbi_base2 = pci->dbi_base + pcie_dbi2_offset;
> - res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "addr_space");
> - if (!res)
> - return -EINVAL;
>
> - ep->phys_base = res->start;
> - ep->addr_size = resource_size(res);
> - ep->page_size = SZ_64K;
> + pci->dbi_base2 = pci->dbi_base + pcie_dbi2_offset;
>
> ret = dw_pcie_ep_init(ep);
> if (ret) {
> --
> 2.34.1
>

--
மணிவண்ணன் சதாசிவம்