Re: [PATCH v7 09/16] dt-bindings: imx6q-pcie: Clean up irrationality clocks check

Manivannan Sadhasivam
2024-01-07T05:34:19Z

On Wed, Dec 27, 2023 at 01:27:20PM -0500, Frank Li wrote:
> The bindings referencing this file already define these constraints for
> each of the variants, so the if not: then: is redundant.
>
> Acked-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>

Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

- Mani

> ---
>
> Notes:
> Change from v6 to v7
> - rewrite git commit message by using simple words
> Change from v5 to v6
> - rewrite git commit message and explain why remove it safely.
> - Add Rob's Ack
> Change from v1 to v4
> - new patch at v4
>
> .../bindings/pci/fsl,imx6q-pcie-common.yaml | 16 ----------------
> 1 file changed, 16 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml
> index 8f39b4e6e8491..a284a27c5e873 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml
> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml
> @@ -150,22 +150,6 @@ allOf:
> - {}
> - const: pcie_phy
> - const: pcie_aux
> - - if:
> - properties:
> - compatible:
> - not:
> - contains:
> - enum:
> - - fsl,imx6sx-pcie
> - - fsl,imx8mq-pcie
> - - fsl,imx6sx-pcie-ep
> - - fsl,imx8mq-pcie-ep
> - then:
> - properties:
> - clocks:
> - maxItems: 3
> - clock-names:
> - maxItems: 3
>
> - if:
> properties:
> --
> 2.34.1
>

--
மணிவண்ணன் சதாசிவம்