From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bmailout3.hostsharing.net (bmailout3.hostsharing.net [176.9.242.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 056554CB3C; Thu, 11 Jan 2024 15:06:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=h08.hostsharing.net Received: from h08.hostsharing.net (h08.hostsharing.net [83.223.95.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS RSA CA G1" (verified OK)) by bmailout3.hostsharing.net (Postfix) with ESMTPS id 3C5A3100CF15A; Thu, 11 Jan 2024 16:06:43 +0100 (CET) Received: by h08.hostsharing.net (Postfix, from userid 100393) id 0CEEB36472; Thu, 11 Jan 2024 16:06:43 +0100 (CET) Date: Thu, 11 Jan 2024 16:06:43 +0100 From: Lukas Wunner To: Manivannan Sadhasivam Cc: Dan Williams , Bartosz Golaszewski , Kalle Valo , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Catalin Marinas , Will Deacon , Bjorn Helgaas , Heiko Stuebner , Jernej Skrabec , Chris Morgan , Linus Walleij , Geert Uytterhoeven , Arnd Bergmann , Neil Armstrong , =?iso-8859-1?Q?N=EDcolas_F_=2E_R_=2E_A_=2E?= Prado , Marek Szyprowski , Peng Fan , Robert Richter , Jonathan Cameron , Terry Bowman , Kuppuswamy Sathyanarayanan , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Huacai Chen , Alex Elder , Srini Kandagatla , Greg Kroah-Hartman , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, Bartosz Golaszewski Subject: Re: [RFC 3/9] PCI/portdrv: create platform devices for child OF nodes Message-ID: <20240111150643.GB28409@wunner.de> References: <20240104130123.37115-1-brgl@bgdev.pl> <20240104130123.37115-4-brgl@bgdev.pl> <20240109144327.GA10780@wunner.de> <20240110132853.GA6860@wunner.de> <659f00ed271b3_5cee2942@dwillia2-xfh.jf.intel.com.notmuch> <20240111124009.GA3003@thinkpad> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240111124009.GA3003@thinkpad> User-Agent: Mutt/1.10.1 (2018-07-13) On Thu, Jan 11, 2024 at 06:10:09PM +0530, Manivannan Sadhasivam wrote: > The primary reason for plugging the power sequencing into portdrv is due to > portdrv binding with all the bridge devices and acting as management driver > for the bridges. As I've said before, portdrv not only binds to bridges but also Root Complex Event Collectors. And you most likely don't want to populate child DT nodes for those. > This is where exactly the power sequencing part needs to be plugged > in IMO. But if the idea of the portdrv is just to expose services based on > interrupts, then please suggest a better place to plug this power sequencing > part. Again, I'm suggesting to put this into of_pci_make_dev_node(). Thanks, Lukas