From: Bjorn Helgaas <helgaas@kernel.org>
To: "Wang, Qingshun" <qingshun.wang@linux.intel.com>
Cc: linux-pci@vger.kernel.org, chao.p.peng@linux.intel.com,
chao.p.peng@intel.com, erwin.tsaur@intel.com,
feiting.wanyan@intel.com, qingshun.wang@intel.com,
"Andy Shevchenko" <andriy.shevchenko@intel.com>,
"Luck, Tony" <tony.luck@intel.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: Re: [PATCH 1/4] pci/aer: Store more information in aer_err_info
Date: Fri, 12 Jan 2024 10:32:51 -0600 [thread overview]
Message-ID: <20240112163251.GA2271088@bhelgaas> (raw)
In-Reply-To: <20240111073227.31488-2-qingshun.wang@linux.intel.com>
Please update subject lines of all these patches to match the
capitalization of drivers/pci/ history.
On Thu, Jan 11, 2024 at 03:32:16PM +0800, Wang, Qingshun wrote:
> Store status and mask of both correctable and uncorrectable errors in
> aer_err_info. Severity of uncorrectable errors and the values of Device
> Status register is also recorded in order to filter out errors that
> cannot cause Advisory Non-Fatal error.
>
> Refactor rest of the code to use cor/uncor_status and cor/uncor_mask
> fields instead of status and mask fields.
Can you say something here about the benefit of doing this? This text
essentially describes the code in English, but we can read the code.
What we need here in the commit log is the *reason* for making this
change.
Bjorn
next prev parent reply other threads:[~2024-01-12 16:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-11 7:32 [PATCH 0/4] pci/aer: Handle Advisory Non-Fatal properly Wang, Qingshun
2024-01-11 7:32 ` [PATCH 1/4] pci/aer: Store more information in aer_err_info Wang, Qingshun
2024-01-11 11:27 ` Ilpo Järvinen
2024-01-12 3:21 ` Wang, Qingshun
2024-01-12 16:32 ` Bjorn Helgaas [this message]
2024-01-16 8:35 ` Wang, Qingshun
2024-01-11 7:32 ` [PATCH 2/4] pci/aer: Handle Advisory Non-Fatal properly Wang, Qingshun
2024-01-12 16:35 ` Bjorn Helgaas
2024-01-16 8:42 ` Wang, Qingshun
2024-01-11 7:32 ` [PATCH 3/4] pci/aer: Fetch information for FTrace Wang, Qingshun
2024-01-11 7:32 ` [PATCH 4/4] ras: Trace more information in aer_event Wang, Qingshun
2024-01-12 3:23 ` [PATCH 0/4] pci/aer: Handle Advisory Non-Fatal properly Wang, Qingshun
2024-01-12 16:41 ` Bjorn Helgaas
2024-01-16 8:32 ` Wang, Qingshun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240112163251.GA2271088@bhelgaas \
--to=helgaas@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=chao.p.peng@intel.com \
--cc=chao.p.peng@linux.intel.com \
--cc=erwin.tsaur@intel.com \
--cc=feiting.wanyan@intel.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-pci@vger.kernel.org \
--cc=qingshun.wang@intel.com \
--cc=qingshun.wang@linux.intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox