From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52D6546426 for ; Fri, 2 Feb 2024 12:43:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706877827; cv=none; b=ZmHrh+5t9jyw2NfZ/9gBLkeUqc6zh1Rloux9O52Fcp3Eh0MEKI3k9z6YZsuzZCLYaA1OizB9c1AktcLEMdcRNJsAZnGqWSNsVUfrcvfU6qQ/kDS203RLC/SWqosTJfEdpMMwyQz04WDZJawaFwg8Xf3NTTc0wzLEyhw7/dJ1l10= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706877827; c=relaxed/simple; bh=tj1CLBp7VIANs+EBehg+RJQhsJ0eFvzjfYM3FwLMB8E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OC7hGyNqISbmucP0tu4keym+VYCQQ2OQ9VAQs+DkqsDAAysb7JW3r1surNnV8GPL65z8XQ+oF3i3qDurujbXJmY9Y+BJd60o6vl8oaijcSWW+fctABpWOX6/kH3N0y6NaPEGRG1hOvWwq3vDWpEcmNYXdquI4no23Qoz9pjDt7Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=SDhr1bop; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SDhr1bop" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-6de287449f1so1433144b3a.2 for ; Fri, 02 Feb 2024 04:43:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706877825; x=1707482625; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=L9FESmdqRHWW100RpTBsBq8yPHH7qEEPiTE/zbAOfuA=; b=SDhr1bopjtxDq16hlQJpJ/Qx052J5cu19f8TsI1dKlyNp32jJ6pnpK9y777K4J+Q6n 3Vw4lTtUldIAZvGsVyLpgF8qTtrMCPqqM01313ppc6m3utdUysENTOSiJy+cXTeASJeD gmSWqbSMsiUTrcqjppoq7+1GSfU3VDxrVRDblEusEsaac9/osBcj4O2hAJ6gsRavjV+d DlHwUJsC8rt/NfE+/CKl0S92z4uSIdsRcy88mLUP/F/6pcGKtFCOACSR0WHSk5064wLB wmFj0yAmm0u26bRqYLmlxyFAYnnqWjHHdT3oBHB2xUrRFxNyXOinpgubaNPsWdkkXLab Txkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706877825; x=1707482625; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=L9FESmdqRHWW100RpTBsBq8yPHH7qEEPiTE/zbAOfuA=; b=Gm7Djy2lVfGeOf7owQ8XbSjph5iCOSxim5/Tie47TCdKDos3JbC3Qr0ukuwRsvW7gs VYdCmo418UEk6Ch6RjxKNqHxp6zYIj/cU1lkRxYeZZGeeU7WWdIbx+/TCfrc5mbI2e5g uZCg5TWeLrB/aSaEclGnxPTVIjlqzfjqhEvnx94fRq9YGj+3YsHCerMux3QsfT6FSwgM hf8Q6WUfZw3rrNTGVQlhcLhRa6b7snms4bKIIsWglC3z461zUgfZOVRACSdaiauqzvEz 4jiMcRYvbhEUEcQZJUzSxIxVL+kLpRee95eJeS5crxKd9CURm0mX+m8mDfqVddJ/mp/x nLsQ== X-Gm-Message-State: AOJu0Yw32oXlbHww3WMqZEqSM460UIYG4Tp2UQOvYyRUF/S41Q/vS/GU V/53wvd1im15QDCsVaqNylozJqdpaxjVsq0zJjGLFib0gGw7/VVNU63u2dyffA== X-Google-Smtp-Source: AGHT+IHESOHJ8cWgQzgEjYBv8OWlxVRz/PcZ05Fwo0cb1mOSPNQNp5xpPehWQdHJA4Ba01V18NtaHA== X-Received: by 2002:a05:6a20:3c91:b0:19c:7672:af4f with SMTP id b17-20020a056a203c9100b0019c7672af4fmr9002476pzj.61.1706877825584; Fri, 02 Feb 2024 04:43:45 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWPmT2VqJaNyvNg5+co+4qpwvXqVptIjKTOsdryKgX566PiL11yq1irVf+15INBRQVb7cQ6AErXMt4AAR0TpWyRtzkXPVAgpqRE5sgrcoBJAE1LJQe7vtQKY+LfK0v381JVLjm5EYYwKp6i9LWxIb3TpTMALpiAIqfed+mKXWkdFbb4fAPFFgtSFA3BVLrD4sBgY5+tq/nSsnPASDF7n3XH91ecdDWxgaJxQqwvKh6ex3hHSnrNrn2Auk3aNLN1/6jLMw+ZFuMT0gCJkDI9jwWFjh9bQBsmqoT0ToyWZdNS9J0Xq9T0k7eS3jwAMAELF80yO45qq/+m8QkjpXDZnCwdsQ== Received: from thinkpad ([120.56.198.122]) by smtp.gmail.com with ESMTPSA id l4-20020a170903244400b001d8accb025fsm1487776pls.197.2024.02.02.04.43.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 04:43:45 -0800 (PST) Date: Fri, 2 Feb 2024 18:13:39 +0530 From: Manivannan Sadhasivam To: Abel Vesa Cc: neil.armstrong@linaro.org, Konrad Dybcio , Bjorn Andersson , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , linux-pci@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] PCI: qcom: Add X1E80100 PCIe support Message-ID: <20240202124339.GE8020@thinkpad> References: <20240129-x1e80100-pci-v2-0-a466d10685b6@linaro.org> <20240129-x1e80100-pci-v2-2-a466d10685b6@linaro.org> <30360d96-4513-40c4-9646-e3ae09121fa7@linaro.org> <20240202084157.GE2961@thinkpad> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Feb 02, 2024 at 12:31:32PM +0200, Abel Vesa wrote: > On 24-02-02 14:11:57, Manivannan Sadhasivam wrote: > > On Fri, Feb 02, 2024 at 09:13:25AM +0100, neil.armstrong@linaro.org wrote: > > > On 01/02/2024 20:20, Konrad Dybcio wrote: > > > > On 29.01.2024 12:10, Abel Vesa wrote: > > > > > Add the compatible and the driver data for X1E80100. > > > > > > > > > > Signed-off-by: Abel Vesa > > > > > --- > > > > > drivers/pci/controller/dwc/pcie-qcom.c | 1 + > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c > > > > > index 10f2d0bb86be..2a6000e457bc 100644 > > > > > --- a/drivers/pci/controller/dwc/pcie-qcom.c > > > > > +++ b/drivers/pci/controller/dwc/pcie-qcom.c > > > > > @@ -1642,6 +1642,7 @@ static const struct of_device_id qcom_pcie_match[] = { > > > > > { .compatible = "qcom,pcie-sm8450-pcie0", .data = &cfg_1_9_0 }, > > > > > { .compatible = "qcom,pcie-sm8450-pcie1", .data = &cfg_1_9_0 }, > > > > > { .compatible = "qcom,pcie-sm8550", .data = &cfg_1_9_0 }, > > > > > + { .compatible = "qcom,pcie-x1e80100", .data = &cfg_1_9_0 }, > > > > > > > > I swear I'm not delaying everything related to x1 on purpose.. > > > > > > > > But.. > > > > > > > > Would a "qcom,pcie-v1.9.0" generic match string be a good idea? > > > > > > Yes as fallback, this is why I used qcom,pcie-sm8550 as fallback for SM8650. > > > > > > > Right. Fallback should be used here also. > > So after digging a bit more ... > > Nope. Fallback approach doesn't work for X1E80100. > > The ddrss_sf_qtb clock is, on this platform, under RPMH control, > and therefore not registered by the GCC. This implies this clock cannot > be provided to the pcie controller node in DT, which implies the > bindings are different when compared to sm8550. So dedicated compatible > is needed. > > So this patchset should remain as is. > Apologies! I just went with the conversation without cross checking the DT binding. You have already listed it as a separate entry. - Mani -- மணிவண்ணன் சதாசிவம்