Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: "Ricardo B. Marliere" <ricardo@marliere.net>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] PCI: make pcie_port_bus_type const
Date: Thu, 8 Feb 2024 15:00:58 -0600	[thread overview]
Message-ID: <20240208210058.GA971698@bhelgaas> (raw)
In-Reply-To: <20240208-bus_cleanup-pci2-v1-1-5e578210b6f2@marliere.net>

On Thu, Feb 08, 2024 at 04:41:46PM -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the pcie_port_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
> 
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>

Applied to pci/misc for v6.9, thanks!

Subject line adjusted to:

  PCI: Make pcie_port_bus_type const

to match history.

> ---
>  drivers/pci/pci-driver.c   | 2 +-
>  drivers/pci/pcie/portdrv.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c
> index ec838f2e892e..a29098e24683 100644
> --- a/drivers/pci/pci-driver.c
> +++ b/drivers/pci/pci-driver.c
> @@ -1705,7 +1705,7 @@ static int pcie_port_bus_match(struct device *dev, struct device_driver *drv)
>  	return 1;
>  }
>  
> -struct bus_type pcie_port_bus_type = {
> +const struct bus_type pcie_port_bus_type = {
>  	.name		= "pci_express",
>  	.match		= pcie_port_bus_match,
>  };
> diff --git a/drivers/pci/pcie/portdrv.h b/drivers/pci/pcie/portdrv.h
> index 1f3803bde7ee..12c89ea0313b 100644
> --- a/drivers/pci/pcie/portdrv.h
> +++ b/drivers/pci/pcie/portdrv.h
> @@ -96,7 +96,7 @@ struct pcie_port_service_driver {
>  int pcie_port_service_register(struct pcie_port_service_driver *new);
>  void pcie_port_service_unregister(struct pcie_port_service_driver *new);
>  
> -extern struct bus_type pcie_port_bus_type;
> +extern const struct bus_type pcie_port_bus_type;
>  
>  struct pci_dev;
>  
> 
> ---
> base-commit: cc24b2d080dca2ce1c89a8a71c00bdf21155f357
> change-id: 20240208-bus_cleanup-pci2-61fe9c495d08
> 
> Best regards,
> -- 
> Ricardo B. Marliere <ricardo@marliere.net>
> 

  reply	other threads:[~2024-02-08 21:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-08 19:41 [PATCH] PCI: make pcie_port_bus_type const Ricardo B. Marliere
2024-02-08 21:00 ` Bjorn Helgaas [this message]
2024-02-09  9:42   ` Ricardo B. Marliere
2024-02-09 19:53 ` Kuppuswamy Sathyanarayanan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240208210058.GA971698@bhelgaas \
    --to=helgaas@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=ricardo@marliere.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox