From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D2669130AF2 for ; Fri, 16 Feb 2024 16:54:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708102456; cv=none; b=bx0HlGOBHaDfcBR8jkE/9sgKiYGYxpQk/uGJtIRocq4x8/jkv7+nLKPmbds7i9ZXHGGcF/rAAtax6ecSuyPm1V5orQVzd8VblOhtO6WGaQAbdo/+VfBCQEf8QskJmq0DduNRnuFX5CbM6+2fMBXjw49kd6C2n2RCIzRNB90yTZM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708102456; c=relaxed/simple; bh=Y91UWNzXuH8p9y2IvbH82XnOrZASUCU2q9704Gj6jR8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mgvSNbc7fSBhTLgDUKosdxBBHluCdiLemvTIPNUIZBzxYjY3o84s4JhQ4g8yRQqI7/WmvpPr9Te10UZzeGjs1VDwCCkPR5sz+J/W/Crx0Yp/KiJNL04cdst72ayTP0VnGknddd6eEBT8VeksyXwiRuJIQUgwsjk0gVmwkwWZqoM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=SMRdlQnU; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SMRdlQnU" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-6d9f94b9186so1875073b3a.0 for ; Fri, 16 Feb 2024 08:54:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1708102454; x=1708707254; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=br2N/R8PHJEVGm+jIHqD2c6+5tUx5kxjgFiSBw/i4S8=; b=SMRdlQnUiv+6LrQ2ehvig9k9l5PaWzqQsSAhpqnhg3jFBuukeqJ5KBl3oiNaUC6/nA 30CJEXE6F7rc4/CTEfQ1I2L7c0BvVKXKj2d7cHIW+lvbJoXWstUhW3vsgS/sw1C+V9wZ 0IrIuTx8B3KBVaM1A5+y1yTn4WMhHpqKOuG+XxFQx6CShjM0JdC2FQOsiEXvDUr3Jw5d X/SOeJBnQlvBN76yMw2miOxyssUgDnFG7TaT474zko52/yM9D1D/7PRZB0rOS2CXtZg1 3KEDx1XWENcW93LB7jz1J+3Ssr7BpqYnx7CH4bnioOowhSN0xJbT3ENUzYyn1IqcQJqf qJdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708102454; x=1708707254; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=br2N/R8PHJEVGm+jIHqD2c6+5tUx5kxjgFiSBw/i4S8=; b=n1Ks4Ae01G1mtJz8wOtHCR7g5vPLuRzBaaSASEVz2OhFJIQp1n9BAfUHjIQN5ApUOY sj0ECNVAwPby1TVG7CWZ5BEjTk9896fX/p6w6NoBfsHOuEZh2k7ud1zj7Np2MfyESpJd DCUN3Yyzxqg9cj2ItauQDpp+EdFdws3jxZz0q3Az85fQk8eLo0+rw2h3BqLDaQeYvezV ej3dxAriJrlFypCaRhgjNiyv5LhRybz1SNYIBJBrAq2pcDsPBzvd5OhT3cFJGD3V/4ql APmrGN0GOxn53ZVOSxCyJzVTDvoq6FGfUrEvAKvWUxI0R+rWtyQNg/6ElVS7iwUohqi6 Z3bw== X-Forwarded-Encrypted: i=1; AJvYcCU5fOTW1vj3Z17GHtpx5owsdQxXqONM+5zKxxHimhRjolwG3ZITllPfVA3o5FxHeNz/FgP7pM75FYcvjCHzoz8bd5w6eI9ofi3T X-Gm-Message-State: AOJu0YxGJ8rKG/sqa7twvstZoeNUKtkievkIbsk8alepgCIDzvCEG/OW g+tV5NJorypZm4jEBD7/bARuOmCKFhFVjMjHVmg0zAiE8pvETRtAaaYGv+9jfg== X-Google-Smtp-Source: AGHT+IEg7nBZgAV6mmmXqEFA0ksN6sm799MQHapgL/DdyvYAzH6BOQl3qC6EYPbvT0oVYUmjTjUyCg== X-Received: by 2002:aa7:8a56:0:b0:6e0:f2a6:abde with SMTP id n22-20020aa78a56000000b006e0f2a6abdemr5363330pfa.5.1708102452975; Fri, 16 Feb 2024 08:54:12 -0800 (PST) Received: from thinkpad ([120.138.12.48]) by smtp.gmail.com with ESMTPSA id gu8-20020a056a004e4800b006dde35245d8sm173857pfb.58.2024.02.16.08.54.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Feb 2024 08:54:12 -0800 (PST) Date: Fri, 16 Feb 2024 22:24:06 +0530 From: Manivannan Sadhasivam To: Krzysztof Kozlowski Cc: Johan Hovold , Johan Hovold , Bjorn Andersson , Bjorn Helgaas , Konrad Dybcio , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/10] dt-bindings: PCI: qcom: Do not require 'msi-map-mask' Message-ID: <20240216165406.GD39963@thinkpad> References: <20240212165043.26961-1-johan+linaro@kernel.org> <20240212165043.26961-3-johan+linaro@kernel.org> <59bd6e54-0d5d-4e1a-818a-475a96c223ff@linaro.org> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <59bd6e54-0d5d-4e1a-818a-475a96c223ff@linaro.org> On Wed, Feb 14, 2024 at 02:38:57PM +0100, Krzysztof Kozlowski wrote: > On 14/02/2024 13:54, Johan Hovold wrote: > > On Wed, Feb 14, 2024 at 01:01:20PM +0100, Krzysztof Kozlowski wrote: > >> On 12/02/2024 17:50, Johan Hovold wrote: > >>> Whether the 'msi-map-mask' property is needed or not depends on how the > >>> MSI interrupts are mapped and it should therefore not be described as > >>> required. > >> > >> I could imagine that on all devices the interrupts are mapped in a way > >> you need to provide msi-map-mask. IOW, can there be a Qualcomm platform > >> without msi-map-mask? > > > > I don't have access to the documentation so I'll leave that for you guys > > to determine. I do note that the downstream DT does not use it and that > > we have a new devicetree in linux-next which also does not have it: > > > > https://lore.kernel.org/r/20240125-topic-sm8650-upstream-pcie-its-v1-1-cb506deeb43e@linaro.org > > > > But at least the latter looks like an omission that should be fixed. > > Hm, either that or the mask for sm8450 was not needed as well. Anyway, > thanks for explanation, appreciated! > msi-map-mask is definitely needed as it would allow all the devices under the same bus to reuse the MSI identifier. Currently, excluding this property will not cause any issue since there is a single device under each bus. But we cannot assume that is going to be the case on all boards. I will submit a patch to fix SM8650. - Mani -- மணிவண்ணன் சதாசிவம்