* [pci:wip/2402-bjorn-osc-dpc 3/3] drivers/pci/pci-acpi.c:1424:9: error: implicit declaration of function 'pci_acpi_add_edr_notifier'; did you mean 'pci_acpi_add_pm_notifier'?
@ 2024-02-27 10:31 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2024-02-27 10:31 UTC (permalink / raw)
To: Bjorn Helgaas; +Cc: oe-kbuild-all, linux-pci
tree: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git wip/2402-bjorn-osc-dpc
head: f76758eebe9e2f81b37e41d2bdc70825cdb879d7
commit: f76758eebe9e2f81b37e41d2bdc70825cdb879d7 [3/3] PCI/DPC: Encapsulate pci_acpi_add_edr_notifier()
config: x86_64-defconfig (https://download.01.org/0day-ci/archive/20240227/202402271824.MzpOujLC-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-12) 11.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240227/202402271824.MzpOujLC-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402271824.MzpOujLC-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/pci/pci-acpi.c: In function 'pci_acpi_setup':
>> drivers/pci/pci-acpi.c:1424:9: error: implicit declaration of function 'pci_acpi_add_edr_notifier'; did you mean 'pci_acpi_add_pm_notifier'? [-Werror=implicit-function-declaration]
1424 | pci_acpi_add_edr_notifier(pci_dev);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
| pci_acpi_add_pm_notifier
drivers/pci/pci-acpi.c: In function 'pci_acpi_cleanup':
>> drivers/pci/pci-acpi.c:1451:9: error: implicit declaration of function 'pci_acpi_remove_edr_notifier'; did you mean 'pci_acpi_remove_pm_notifier'? [-Werror=implicit-function-declaration]
1451 | pci_acpi_remove_edr_notifier(pci_dev);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
| pci_acpi_remove_pm_notifier
cc1: some warnings being treated as errors
vim +1424 drivers/pci/pci-acpi.c
617654aae50eb5 Mika Westerberg 2018-08-16 1417
4795448117824c Rafael J. Wysocki 2021-09-18 1418 void pci_acpi_setup(struct device *dev, struct acpi_device *adev)
d2e5f0c16ad60a Rafael J. Wysocki 2012-12-23 1419 {
d2e5f0c16ad60a Rafael J. Wysocki 2012-12-23 1420 struct pci_dev *pci_dev = to_pci_dev(dev);
f084280cd34e37 Rafael J. Wysocki 2013-12-29 1421
e33caa82e221b0 Aaron Lu 2015-03-25 1422 pci_acpi_optimize_delay(pci_dev, adev->handle);
99b50be9d8ec9e Rajat Jain 2020-07-07 1423 pci_acpi_set_external_facing(pci_dev);
ac1c8e35a3262d Kuppuswamy Sathyanarayanan 2020-03-23 @1424 pci_acpi_add_edr_notifier(pci_dev);
e33caa82e221b0 Aaron Lu 2015-03-25 1425
f084280cd34e37 Rafael J. Wysocki 2013-12-29 1426 pci_acpi_add_pm_notifier(adev, pci_dev);
f084280cd34e37 Rafael J. Wysocki 2013-12-29 1427 if (!adev->wakeup.flags.valid)
d2e5f0c16ad60a Rafael J. Wysocki 2012-12-23 1428 return;
d2e5f0c16ad60a Rafael J. Wysocki 2012-12-23 1429
d2e5f0c16ad60a Rafael J. Wysocki 2012-12-23 1430 device_set_wakeup_capable(dev, true);
6299cf9ec3985c Mika Westerberg 2018-09-27 1431 /*
6299cf9ec3985c Mika Westerberg 2018-09-27 1432 * For bridges that can do D3 we enable wake automatically (as
6299cf9ec3985c Mika Westerberg 2018-09-27 1433 * we do for the power management itself in that case). The
6299cf9ec3985c Mika Westerberg 2018-09-27 1434 * reason is that the bridge may have additional methods such as
6299cf9ec3985c Mika Westerberg 2018-09-27 1435 * _DSW that need to be called.
6299cf9ec3985c Mika Westerberg 2018-09-27 1436 */
6299cf9ec3985c Mika Westerberg 2018-09-27 1437 if (pci_dev->bridge_d3)
6299cf9ec3985c Mika Westerberg 2018-09-27 1438 device_wakeup_enable(dev);
6299cf9ec3985c Mika Westerberg 2018-09-27 1439
8370c2dc4c7b91 Rafael J. Wysocki 2017-06-24 1440 acpi_pci_wakeup(pci_dev, false);
53b22f900c2d28 Mika Westerberg 2019-06-25 1441 acpi_device_power_add_dependent(adev, dev);
62d528712c1db6 Rafael J. Wysocki 2022-04-04 1442
62d528712c1db6 Rafael J. Wysocki 2022-04-04 1443 if (pci_is_bridge(pci_dev))
62d528712c1db6 Rafael J. Wysocki 2022-04-04 1444 acpi_dev_power_up_children_with_adr(adev);
d2e5f0c16ad60a Rafael J. Wysocki 2012-12-23 1445 }
d2e5f0c16ad60a Rafael J. Wysocki 2012-12-23 1446
4795448117824c Rafael J. Wysocki 2021-09-18 1447 void pci_acpi_cleanup(struct device *dev, struct acpi_device *adev)
d2e5f0c16ad60a Rafael J. Wysocki 2012-12-23 1448 {
6299cf9ec3985c Mika Westerberg 2018-09-27 1449 struct pci_dev *pci_dev = to_pci_dev(dev);
d2e5f0c16ad60a Rafael J. Wysocki 2012-12-23 1450
ac1c8e35a3262d Kuppuswamy Sathyanarayanan 2020-03-23 @1451 pci_acpi_remove_edr_notifier(pci_dev);
f084280cd34e37 Rafael J. Wysocki 2013-12-29 1452 pci_acpi_remove_pm_notifier(adev);
6299cf9ec3985c Mika Westerberg 2018-09-27 1453 if (adev->wakeup.flags.valid) {
53b22f900c2d28 Mika Westerberg 2019-06-25 1454 acpi_device_power_remove_dependent(adev, dev);
6299cf9ec3985c Mika Westerberg 2018-09-27 1455 if (pci_dev->bridge_d3)
6299cf9ec3985c Mika Westerberg 2018-09-27 1456 device_wakeup_disable(dev);
6299cf9ec3985c Mika Westerberg 2018-09-27 1457
d2e5f0c16ad60a Rafael J. Wysocki 2012-12-23 1458 device_set_wakeup_capable(dev, false);
d2e5f0c16ad60a Rafael J. Wysocki 2012-12-23 1459 }
6299cf9ec3985c Mika Westerberg 2018-09-27 1460 }
d2e5f0c16ad60a Rafael J. Wysocki 2012-12-23 1461
:::::: The code at line 1424 was first introduced by commit
:::::: ac1c8e35a3262d04cc81b07fac6480a3539e3b0f PCI/DPC: Add Error Disconnect Recover (EDR) support
:::::: TO: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
:::::: CC: Bjorn Helgaas <bhelgaas@google.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-02-27 10:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-27 10:31 [pci:wip/2402-bjorn-osc-dpc 3/3] drivers/pci/pci-acpi.c:1424:9: error: implicit declaration of function 'pci_acpi_add_edr_notifier'; did you mean 'pci_acpi_add_pm_notifier'? kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).