From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4B586E60C for ; Fri, 1 Mar 2024 13:15:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709298905; cv=none; b=e4wcCeeSswMAh+Bxmim9R/7ph3SnK4yErFglnvi/uqnm0twPvPt7X3xtJ9PtORjAN+vE5NcZh2JtbSl1axyA3RX7TkJpK3beNGXY7/h88vDIGT7MXeBiuM3aosE56XObiZyK45rdJNUUWMILg3rCdKVbkqG5yPJtTv+IsGg1q90= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709298905; c=relaxed/simple; bh=hTajR1kOQhYONNR+DlufZegiqGvJ4ihTgTAF1u5cu6k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bjixlJc3U2iRI/AZRGZpUSh9omgZbzfRxvL8KMXeikL+PQpXq4lcJ7S+2Zjw9tg/5TYvbGgYFuvjfKArXoc3Y+CVOR8WYFm4MgGJEqJDWs846zkK7ZiQNK+W+svqnUhP0YqJbCro1aiHAmjakl5MbX92eLLs0kagQCV4y7XCsz0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=yfRC5Qd/; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="yfRC5Qd/" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-6e5a232fe80so1062022b3a.0 for ; Fri, 01 Mar 2024 05:15:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709298903; x=1709903703; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=c4xVhW5kr9a0VX3KhZQL/39tJeDBtJNO1wfa+ART7+Y=; b=yfRC5Qd/oLOHEZnJKc7rl6sTdmEKy25X8b3WHymKs4wYRvwpiT3LvmXin1wQGPSybL QWhEtx2KqT9lO1ZPef8hfMZVgz/dG1Lhs+4xbETpHcDaQ3sHRRAoIyosDmqTip2p1RHR 2jSRMFXlgxzleDGvX7zeG5gbyMs3+PqCbMT+pjtEC/3T5R2Tm8A0M7WNV70wJkdJsBjK IxEmOOlLlO+XB6j5UHHwcVCKjqSx1H9Nbvjmfrg0C5VCPeK9ERr5tF206HiIBgNjmd1e 8oWXu01oZtVlbUNDjyYeX7bySaZyBsv9nazQ72zctNmbLWJLUrZceA3HDUwkCqYAZJNB PKHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709298903; x=1709903703; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=c4xVhW5kr9a0VX3KhZQL/39tJeDBtJNO1wfa+ART7+Y=; b=BW7a6HNrjwldKU320yrVxCUCj7R0hUoOFa+jPo/YWSB87CSetjM+Na8scd2939darj 8E3Q8P5tbUZKmVRACVamemcjMAaCuAQtfQGuaKQIZlDnqVg8Fkez2XqEi+cbiQdi8RTA XxlPFK3Rmh2/j7MHIRlgDNaQQDW+PVU0vHiYtlh6E/hXcUWwe3wfEnNsoY5G+GCUQTc3 rTnY4HuONpk+EmVDVRlzZTSYUgnqltsYe3p/8XmnZOjJwHYOJJjkS/tnR2yVcXoNBaCf HNNTi+4jGoD/FtsNpfV/5XbJ1FEkQ52QZz0kFEEL9RKz4OzjSYg4TC+s3Cu53iPKYHD8 wZOQ== X-Forwarded-Encrypted: i=1; AJvYcCXVUmlAhMBnc+EMOPOMU0vaDruSSUEdDW0G+vCXmeReXrk2ISLvnN0NYU21MRxS1TPx1CR8P0cigHnPu2AHj7rPN6fAJVfk+zYe X-Gm-Message-State: AOJu0Yx2oJe5mj88XdvqhCewO8Mo7cnu7S9421sq372lhX5N+u37k8Qd j7DYKLVp9/TPi2fvWC5HuB++U/L5zzdGXe7ZVChLHZaKMJnw9rEY4chuuooB/g== X-Google-Smtp-Source: AGHT+IFNQNung36bGOpauELwOxEpRzqKfYOr0NMTDutbY+58U0qNhiw87Xd4mLrwZVZOKEO0FVJvYw== X-Received: by 2002:a05:6a00:4218:b0:6e5:37cb:64c4 with SMTP id cd24-20020a056a00421800b006e537cb64c4mr2771504pfb.9.1709298902835; Fri, 01 Mar 2024 05:15:02 -0800 (PST) Received: from thinkpad ([2409:40f4:13:3cbc:2484:3780:dcff:ebcf]) by smtp.gmail.com with ESMTPSA id i1-20020a62c101000000b006e56d880015sm3116152pfg.140.2024.03.01.05.14.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Mar 2024 05:15:02 -0800 (PST) Date: Fri, 1 Mar 2024 18:44:45 +0530 From: Manivannan Sadhasivam To: Johan Hovold Cc: Bjorn Helgaas , Johan Hovold , Bjorn Helgaas , Bjorn Andersson , Konrad Dybcio , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 00/12] arm64: dts: qcom: sc8280xp: PCIe fixes and GICv3 ITS enable Message-ID: <20240301131445.GA5414@thinkpad> References: <20240223152124.20042-1-johan+linaro@kernel.org> <20240228220843.GA309344@bhelgaas> <20240229100853.GA2999@thinkpad> <20240229122416.GD2999@thinkpad> <20240229135407.GE2999@thinkpad> <20240301122406.GA2401@thinkpad> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Fri, Mar 01, 2024 at 01:46:15PM +0100, Johan Hovold wrote: > On Fri, Mar 01, 2024 at 05:54:06PM +0530, Manivannan Sadhasivam wrote: > > On Thu, Feb 29, 2024 at 04:37:27PM +0100, Johan Hovold wrote: > > > > I'm all for digging further into this issue with the help of Qualcomm, > > > but I don't think that should block this series as that would leave the > > > link errors that we hit since 6.7 in place and effectively prevent us > > > from enabling the ITS in 6.9. > > > > Sounds fair. I will report back, perhaps with a fix based on what I get to know. > > Sounds good, thanks. > > > But I think it is better to disable L0s in the SoC dtsi itself. That's not only > > because there are patches to essentially disable L0s in 2 of the available > > platforms making use of this Soc, but also you are enabling GIC ITS in the SoC > > dtsi and that may affect sa8540p which is making use of this dtsi. > > I did not do so on purpose as I'm only disabling L0s on machines where > I've confirmed the issue. And the assumption for now is that this is a > machine-level issue. > > > The users of that SoC may have not noticed the errors as you did before, but > > enabling GIC ITS will certainly make the issue visible to them (more likely). > > Sure and that would be good to know as that would give us another data > point which may help determine where the problem lies. Enabling the ITS > will (hopefully) be done in 6.9 so we'll have a whole cycle to disable > L0s where needed. I don't think this should be done before then. > Ok. Let's see what happens :) For the series: Reviewed-by: Manivannan Sadhasivam - Mani -- மணிவண்ணன் சதாசிவம்