From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com [209.85.219.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35473134B7 for ; Mon, 4 Mar 2024 08:19:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709540355; cv=none; b=qNqqaJmnL35iNC1iwxAIA14lrkZnEhjKAXrbyE7w4kfXQD1eoI2LYcUqh2qaNp05wtZMj8qnU3O+bmAee2exC/XCL9JFEym3gz8bLC2TEGO57YepfUDGRxFrUX+oAn4ZSrtQpw6FYZ7N+7oAuaKUcagRrcwK9fzfTqvDJzxI5xI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709540355; c=relaxed/simple; bh=H5uERWY03PMmpXHmr9VmP2Q+Yn+vktnT7Eljnh8Qo9s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Iutatte+t1TX4m45BASrT85vVZUSaQfpn6sLt6JQsXwKPKadDwzhgU57ASiHCKRnTp1uF+S2ii6VmYTrW36HoMzA4s0lvFqYYXJt3MAWyR6tqHR4Le01vu/hu7VWtK3NFqZGG8qQKraxWtRe/pW8g3UqmKnrDCEnWjgqBc4SDs4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Iye9FMvY; arc=none smtp.client-ip=209.85.219.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Iye9FMvY" Received: by mail-yb1-f177.google.com with SMTP id 3f1490d57ef6-dcbf82cdf05so4116468276.2 for ; Mon, 04 Mar 2024 00:19:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709540353; x=1710145153; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=nGaxan9MS5xxwpnuhzQOq+gU3MPaqevKCopu0R9YM7I=; b=Iye9FMvY1Mxl9ba1DIM6exZqxv2w3tmhNabwkzOPFQzyHWkk3ww/BUx20ZE0Mu8osc VKIZ+KTYku6OZM7RP9UMjbysJJwdct9OYF5b1wOhW38kp9OYhn6bJNz991NkYt2c0Hlr 7v2+g0ycRxxXmq+r0ossgxFsbbkgsxXzYsm4kPEfFFh00o2/4sRt3VMOsmwsQFKi5Rtm J8w4x4+5bRrV8O8aJgGhB3o4sTmKCBVPgbX0naIbmibJV01s5p1pDRfYr5gsJevO2GAY BSG2yxYsA2fhSkc+HFkbK/cq61znvWC5QhlsPhFA+rG6ljvDujssljeJs6E39J9AO6Fs hgrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709540353; x=1710145153; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nGaxan9MS5xxwpnuhzQOq+gU3MPaqevKCopu0R9YM7I=; b=e+lTk3UkZiSd0WLqnocHpoT4hwwaMKlD3hv7TGRYn6ge0C5AnaN29Xo4wwaunU/py7 uGhZYTtnTiLlxV76M1naF50V1FqokI9K4REd8dQe6/eM/7yG/mgamhCPUJwglHYB0ksn lT9CrGUZbS6yWlp/rTqyLx/Xfi9ljB2XIkNAwGAmYBpWNA4V/mVBNE3Iw1U9IavViWah 3SneD5s24VpnBWIL3OoBC4tzGqvkY8GoUGDf/l4q5ke0NuVvvo5vFhk96gpAl2DHWjqw JbnAF1DxiGCIDiQho58YshfNubgT8iQlLHqtSSt1WnS62JWLWc3mXDF7hRBOzsAVEMr7 ZPOA== X-Forwarded-Encrypted: i=1; AJvYcCUJIYNn/hjrHHAc/8WUcK5Mev/+GojzJBHRvQylO1UMFVVAt6vybpZyUDmXladMifu5efUIh7aWW4hzvGFATuTOm14IidX8SGC0 X-Gm-Message-State: AOJu0Yxz5Rqv4YqaLM9Ury/oJ7+slLJ0QQWBHM3Du5D1WnBcoONXD4+P pMmnzzXpDanxYe0krzWWt3A0s5oEVqw1UImscMyQY5owbvE+GKG2Iv34nO5+vw== X-Google-Smtp-Source: AGHT+IHL1WHL+wc2Bkuxv4RuAVn4VY861FeJv8fqtZvJsgPjzKqwuQFKnCSzgHkDfczowkgJ09KEpA== X-Received: by 2002:a25:7412:0:b0:dcc:79ab:e51a with SMTP id p18-20020a257412000000b00dcc79abe51amr6318413ybc.57.1709540353345; Mon, 04 Mar 2024 00:19:13 -0800 (PST) Received: from thinkpad ([117.202.187.165]) by smtp.gmail.com with ESMTPSA id ks17-20020ac86211000000b0042ed81f5297sm2298830qtb.35.2024.03.04.00.19.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Mar 2024 00:19:13 -0800 (PST) Date: Mon, 4 Mar 2024 13:48:59 +0530 From: Manivannan Sadhasivam To: Niklas Cassel Cc: Jingoo Han , Gustavo Pimentel , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Marek Vasut , Yoshihiro Shimoda , Thierry Reding , Jonathan Hunter , Kishon Vijay Abraham I , Vidya Sagar , Vignesh Raghavendra , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Minghuan Lian , Mingkai Hu , Roy Zang , Kunihiko Hayashi , Masami Hiramatsu , Kishon Vijay Abraham I , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v8 10/10] PCI: dwc: ep: Add Kernel-doc comments for APIs Message-ID: <20240304081859.GI2647@thinkpad> References: <20240224-pci-dbi-rework-v8-0-64c7fd0cfe64@linaro.org> <20240224-pci-dbi-rework-v8-10-64c7fd0cfe64@linaro.org> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Thu, Feb 29, 2024 at 01:56:23PM +0100, Niklas Cassel wrote: > Hello Mani, > > On Sat, Feb 24, 2024 at 12:24:16PM +0530, Manivannan Sadhasivam wrote: > > All of the APIs are missing the Kernel-doc comments. Hence, add them. > > > > Signed-off-by: Manivannan Sadhasivam > > --- > > drivers/pci/controller/dwc/pcie-designware-ep.c | 92 +++++++++++++++++++++++++ > > 1 file changed, 92 insertions(+) > > > > diff --git a/drivers/pci/controller/dwc/pcie-designware-ep.c b/drivers/pci/controller/dwc/pcie-designware-ep.c > > index fed4c2936c78..cdcb33a279db 100644 > > --- a/drivers/pci/controller/dwc/pcie-designware-ep.c > > +++ b/drivers/pci/controller/dwc/pcie-designware-ep.c > > (snip) > > > @@ -556,6 +606,12 @@ int dw_pcie_ep_raise_msix_irq(struct dw_pcie_ep *ep, u8 func_no, > > return 0; > > } > > > > +/** > > + * dw_pcie_ep_cleanup - Cleanup DWC EP resources > > + * @ep: DWC EP device > > + * > > + * Cleans up the DWC EP specific resources like eDMA etc... > > I think that you should mention that this is only for glue drivers that > use PERST# handling, so that other glue drivers do no start using it :) > You are right. Will add the wording. - Mani -- மணிவண்ணன் சதாசிவம்