From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1834539AD5 for ; Sun, 10 Mar 2024 18:51:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710096712; cv=none; b=E+vVoE/uFjYtTab9kMmYzbnfLRRuHc8Be/mUCDCJr3pBlBzMGORliln2ZkTUbFz7JUAVLw0JMMBT+zAHkNc3RkfQO4qyfwVkRl8yVO4V5yi/sxhyOpQ0w/LTlqJjJCb84EP70RBhvvhzKurbiAhqkoZ+zIKuT0q63GARCAuQsI8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710096712; c=relaxed/simple; bh=gpJYcZAqHZXYAL3xiwjeB0bCf8k/B0nLu80lgS4FraY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cbFC9u0mpgYa86Q/fO7XXy6cKDFc6BgkOP7tgkSPDMpqK/W7ROdCosbL853GpV2wAtBVKVRh0tmh50AwjNKfOxYs3G7QcEPDVb6HqlMZ6sFQ8l8Fo8vE0d8UsJzHTtNVBul/vmsgXBGVXPPysixjMLLTa6ZjHYIJbm+v2yR4kMI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.com; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4132b04d735so45025e9.1 for ; Sun, 10 Mar 2024 11:51:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710096709; x=1710701509; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=beW9h7nVpsHWDV+bR+YHIZbD3xhNNllIEvrndz0rE5Q=; b=FBLg4FbiTeMiMt40bGba0ADd2ezgJx5BjilzvoKIcSQOGaT4rEdMb6pg4Sd2opLPKJ ENaolwHQnceYx/+MWGhXdJarLjTS1I762h/nFPdXDhz4PHR0saAwO0+4Q44RsD2NNWRd fj/g/a1lWNWvUg7dDw1BOmbV61xYanH8c9Q2ocXLjbMSpxSpGCiKaIyjqnRhy2vSn0kY uinYbzEuHoiShtVGU9q5hMG9XLcCORCaO6S3RRp5m6vsc6ryiNbrqh5N4Kff58fq73bC 39xdODqEnXquASfTNFBzRwRZlIA8U2AiLdzRx6ZAGG6opdnJJWQSEg9fyXiXPGM95OX0 50Lw== X-Forwarded-Encrypted: i=1; AJvYcCWeJBet8h46XE/x9ykQlTInslIFTcAT862BOW4Ir1OOX3tcEns/9ToRYRg0MSwKupF6z4JZDtRx7SGbj+xQ8BeR1Ysrz/06swsE X-Gm-Message-State: AOJu0YzhoohJxTxMDgHhCg0pRoWcmux1uVQDbVVOtskLUR+tNBx2y0MS E5obXcF7JD+xzmMRJPQeX6z65sM6iy8FZ5FyzRheveK38d2p24ts X-Google-Smtp-Source: AGHT+IEKnDGlheH7eBS0Trm1bD3QBo6nvU1rMACl+WjMVbx3D+qaISwx1s6VC9Gqil1gAhnSnkJsJw== X-Received: by 2002:a05:600c:19cf:b0:412:b42c:8ff1 with SMTP id u15-20020a05600c19cf00b00412b42c8ff1mr3865761wmq.21.1710096709151; Sun, 10 Mar 2024 11:51:49 -0700 (PDT) Received: from localhost (fpd11144dd.ap.nuro.jp. [209.17.68.221]) by smtp.gmail.com with ESMTPSA id hg6-20020a05600c538600b00412c8117a34sm6435067wmb.47.2024.03.10.11.51.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 Mar 2024 11:51:48 -0700 (PDT) Date: Mon, 11 Mar 2024 03:51:45 +0900 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Niklas Cassel Cc: Jingoo Han , Gustavo Pimentel , Manivannan Sadhasivam , Lorenzo Pieralisi , Rob Herring , Bjorn Helgaas , Kishon Vijay Abraham I , linux-pci@vger.kernel.org Subject: Re: [PATCH v2] PCI: dwc: endpoint: Fix advertised resizable BAR size Message-ID: <20240310185145.GF2765217@rocinante> References: <20240307111520.3303774-1-cassel@kernel.org> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240307111520.3303774-1-cassel@kernel.org> Hello, > The commit message in commit fc9a77040b04 ("PCI: designware-ep: Configure > Resizable BAR cap to advertise the smallest size") claims that it modifies > the Resizable BAR capability to only advertise support for 1 MB size BARs. > > However, the commit writes all zeroes to PCI_REBAR_CAP (the register which > contains the possible BAR sizes that a BAR be resized to). > > According to the spec, it is illegal to not have a bit set in > PCI_REBAR_CAP, and 1 MB is the smallest size allowed. > > Set bit 4 in PCI_REBAR_CAP, so that we actually advertise support for a > 1 MB BAR size. > > Before: > Capabilities: [2e8 v1] Physical Resizable BAR > BAR 0: current size: 1MB > BAR 1: current size: 1MB > BAR 2: current size: 1MB > BAR 3: current size: 1MB > BAR 4: current size: 1MB > BAR 5: current size: 1MB > After: > Capabilities: [2e8 v1] Physical Resizable BAR > BAR 0: current size: 1MB, supported: 1MB > BAR 1: current size: 1MB, supported: 1MB > BAR 2: current size: 1MB, supported: 1MB > BAR 3: current size: 1MB, supported: 1MB > BAR 4: current size: 1MB, supported: 1MB > BAR 5: current size: 1MB, supported: 1MB Applied to controller/dwc, thank you! [1/1] PCI: dwc: endpoint: Fix advertised resizable BAR size https://git.kernel.org/pci/pci/c/72e34b8593e0 Krzysztof