RE: [PATCH 10/28] drm: amdgpu: Use PCI_IRQ_INTX

Deucher, Alexander
2024-03-25T14:29:35Z

[Public]

> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of
> Damien Le Moal
> Sent: Monday, March 25, 2024 3:09 AM
> To: linux-pci@vger.kernel.org; Bjorn Helgaas <bhelgaas@google.com>;
> Manivannan Sadhasivami <manivannan.sadhasivam@linaro.org>; linux-
> scsi@vger.kernel.org; Martin K . Petersen <martin.petersen@oracle.com>;
> Jaroslav Kysela <perex@perex.cz>; linux-sound@vger.kernel.org; Greg Kroah-
> Hartman <gregkh@linuxfoundation.org>; linux-usb@vger.kernel.org; linux-
> serial@vger.kernel.org; Hans de Goede <hdegoede@redhat.com>; platform-
> driver-x86@vger.kernel.org; ntb@lists.linux.dev; Lee Jones <lee@kernel.org>;
> David Airlie <airlied@gmail.com>; amd-gfx@lists.freedesktop.org; Jason
> Gunthorpe <jgg@ziepe.ca>; linux-rdma@vger.kernel.org; David S . Miller
> <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [PATCH 10/28] drm: amdgpu: Use PCI_IRQ_INTX
>
> Use the macro PCI_IRQ_INTX instead of the deprecated PCI_IRQ_LEGACY
> macro.
>
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>

Feel free to take it through whatever tree makes sense. If you want me to pick it up, let me know.
Acked-by: Alex Deucher <alexander.deucher@amd.com>

> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
> index 7e6d09730e6d..d18113017ee7 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_irq.c
> @@ -279,7 +279,7 @@ int amdgpu_irq_init(struct amdgpu_device *adev)
> adev->irq.msi_enabled = false;
>
> if (!amdgpu_msi_ok(adev))
> - flags = PCI_IRQ_LEGACY;
> + flags = PCI_IRQ_INTX;
> else
> flags = PCI_IRQ_ALL_TYPES;
>
> --
> 2.44.0