From: Bjorn Helgaas <helgaas@kernel.org>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Cc: "lpieralisi@kernel.org" <lpieralisi@kernel.org>,
"kw@linux.com" <kw@linux.com>,
"robh@kernel.org" <robh@kernel.org>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"jingoohan1@gmail.com" <jingoohan1@gmail.com>,
"gustavo.pimentel@synopsys.com" <gustavo.pimentel@synopsys.com>,
"mani@kernel.org" <mani@kernel.org>,
"marek.vasut+renesas@gmail.com" <marek.vasut+renesas@gmail.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v2 5/6] PCI: dwc: rcar-gen4: Add support for other R-Car Gen4 PCIe controller
Date: Wed, 27 Mar 2024 13:14:51 -0500 [thread overview]
Message-ID: <20240327181451.GA1531625@bhelgaas> (raw)
In-Reply-To: <TYCPR01MB110402EB3E15B3471C7F526C7D8342@TYCPR01MB11040.jpnprd01.prod.outlook.com>
On Wed, Mar 27, 2024 at 05:32:57AM +0000, Yoshihiro Shimoda wrote:
> > From: Bjorn Helgaas, Sent: Wednesday, March 27, 2024 5:49 AM
> > > static int rcar_gen4_pcie_get_resources(struct rcar_gen4_pcie *rcar)
> > > {
> > > + rcar->phy_base = devm_platform_ioremap_resource_byname(rcar->pdev, "phy");
> > > + if (IS_ERR(rcar->phy_base))
> > > + return PTR_ERR(rcar->base);
> >
> > I don't get it. This imposes a new requirement (presence of "phy"
> > resource) on the existing SoCs. That doesn't sound right.
>
> According to the dt-binding doc, the existing SoCs are also required
> for the "phy". That's why I didn't add any condition to simplify
> the code.
Is there anything that enforces that? Is it possible that DTs exist
in the field without it? We don't want to break any existing setup.
next prev parent reply other threads:[~2024-03-27 18:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 2:45 [PATCH v2 0/6] PCI: dwc: rcar-gen4: Add R-Car V4H support Yoshihiro Shimoda
2024-03-26 2:45 ` [PATCH v2 1/6] dt-bindings: PCI: rcar-gen4-pci-host: Add R-Car V4H compatible Yoshihiro Shimoda
2024-03-26 2:45 ` [PATCH v2 2/6] dt-bindings: PCI: rcar-gen4-pci-ep: " Yoshihiro Shimoda
2024-03-26 2:45 ` [PATCH v2 3/6] PCI: dwc: Add PCIE_PORT_{FORCE,LANE_SKEW} macros Yoshihiro Shimoda
2024-03-26 2:45 ` [PATCH v2 4/6] PCI: dwc: rcar-gen4: Add a new function pointer for other SoC support Yoshihiro Shimoda
2024-03-26 20:21 ` Bjorn Helgaas
2024-03-27 5:06 ` Yoshihiro Shimoda
2024-03-26 2:45 ` [PATCH v2 5/6] PCI: dwc: rcar-gen4: Add support for other R-Car Gen4 PCIe controller Yoshihiro Shimoda
2024-03-26 20:48 ` Bjorn Helgaas
2024-03-27 5:32 ` Yoshihiro Shimoda
2024-03-27 18:14 ` Bjorn Helgaas [this message]
2024-03-29 2:24 ` Yoshihiro Shimoda
2024-03-26 2:45 ` [PATCH v2 6/6] misc: pci_endpoint_test: Add Device ID for R-Car V4H " Yoshihiro Shimoda
2024-03-26 3:21 ` Frank Li
2024-03-26 5:47 ` Yoshihiro Shimoda
2024-03-26 14:08 ` Frank Li
2024-03-27 5:02 ` Yoshihiro Shimoda
2024-03-27 8:11 ` Geert Uytterhoeven
2024-03-27 8:30 ` Yoshihiro Shimoda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240327181451.GA1531625@bhelgaas \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=marek.vasut+renesas@gmail.com \
--cc=robh@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox