From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1676313B59B for ; Thu, 28 Mar 2024 20:42:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711658529; cv=none; b=V+exX38AONOZDmq2rBR0wzXI5JLMpxdkBvVlBZiFYY//iO5pUepaq2ou0TeZZoV6kA9e0sUSAhvYtcgZmx5K5L+Orm9K5hcMrihhxY3+GQCJknyUASGjlzSM4+kHtG0Y2vnRP6GojCQ7c4w6dlHmBffgM5DBme/eM8rWhtB38Ms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711658529; c=relaxed/simple; bh=dx67GYsTkBy2f4E6+nDiqrEy7ZQNVITGQVNCkKyQWmg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=sFhJyped+9VtPurQ1+mIi921M5b9L/wYAWqLsmIIlicaPrz55FZSuFNATXMrliwh2Oe4GmazZrzELZClXxNkyTeht4aV77GrQwOKAbMne+y1MnlhR7bWNxx18Rq7/C+ch2V/CjxEp8kFyb1mCVd3JEVsI8euptJUfYSQdruEVqs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=N+qsYqKR; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="N+qsYqKR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711658527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ry2KwNiHHETpw/ISNKmQIteSWFjYtHm09Kp2vXN04J8=; b=N+qsYqKRm+i4EuyV8gt3qTCKc459T6zB570+8jUkN86oFtAxQI5g0Uvmnmqn2MYmaH2Mi+ l5d1YUprPt/OrBx75SEdn2w4xVolPGjQOgRsZxY7L0tVF2WBZGmTOidkQQEzxXh38ftTAw FHDNvfptKm+8DedXTlCvTzLRIm/5gVs= Received: from mail-io1-f71.google.com (mail-io1-f71.google.com [209.85.166.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-692-Gq-UVqmPMUGBWoJFmaOoOQ-1; Thu, 28 Mar 2024 16:42:05 -0400 X-MC-Unique: Gq-UVqmPMUGBWoJFmaOoOQ-1 Received: by mail-io1-f71.google.com with SMTP id ca18e2360f4ac-7cc74ea8606so137243439f.2 for ; Thu, 28 Mar 2024 13:42:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711658524; x=1712263324; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ry2KwNiHHETpw/ISNKmQIteSWFjYtHm09Kp2vXN04J8=; b=bMLEIPAtg3FE83OIT/EWnamWxHb8OUaIkhTd66YzATqRidoipc/dcK1romPJ0OLPeq LTvyJmx5wxpyCJpVCUltuEi9vLZo5A7myKrg5foVdN/e2+QGGWAD/B26V7f++6R05XpY VAkyp+9H23R8InPueHILzKSSfcvOCtaPgGvRKBnMOHGnFb9b1ymei2f9rZTzPaA4EGUk KqwIaxjSOV6lWtaaEbkfdxGqqs+Wvkr3SkBk9jfqhwk+npXz8tPPwKpg2F7dsDphx+iB JmwBdTBu+4mYmtrK1q9Ff/aofHoepgzW5owLjEPpBk/hNtdv4cqGARmf6y37FQz6xDjI bdFg== X-Forwarded-Encrypted: i=1; AJvYcCV54zkZUn3hhQslbA7CtHF6LH7GDCmkC+m2Lw11y9bf8qE3vE9qH7Zc+sWy6ZfWcsbzDCG7nt4TZH4fFdLSKVVjTedH1KwSXRxD X-Gm-Message-State: AOJu0Yy9vPI75nkFF5DebKLuEFrBsDAV23ndShUSNpeANN2OAsj2FQgO XtwxREjEninVp7q+26mlHezIHUz6vYWhyhZres18eJbYYD7hpfS2kV0qs9mmym1obYSTSc+zuCW CSwTIvc10w0j7CUnqHRG2GzqzL/kwBq30xGCUzTcWNsrhymqyYPNvQebzNUiaBdxgrQ== X-Received: by 2002:a6b:e610:0:b0:7d0:2e09:914 with SMTP id g16-20020a6be610000000b007d02e090914mr311622ioh.14.1711658524509; Thu, 28 Mar 2024 13:42:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IETxGX4iy66B/NI8RaJIF20PbD28PYM4/zW2oAcxKRRkohptt64R98fB5Lkzx1WzA2aqpVdzw== X-Received: by 2002:a6b:e610:0:b0:7d0:2e09:914 with SMTP id g16-20020a6be610000000b007d02e090914mr311607ioh.14.1711658524241; Thu, 28 Mar 2024 13:42:04 -0700 (PDT) Received: from redhat.com ([38.15.36.11]) by smtp.gmail.com with ESMTPSA id c8-20020a5e8f08000000b007cf185099e6sm602078iok.35.2024.03.28.13.42.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 13:42:03 -0700 (PDT) Date: Thu, 28 Mar 2024 14:42:01 -0600 From: Alex Williamson To: Bjorn Helgaas Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, edmund.raile@proton.me, Takashi Sakamoto Subject: Re: [PATCH v2] PCI: Mark LSI FW643 to avoid bus reset Message-ID: <20240328144201.510f6d5e.alex.williamson@redhat.com> In-Reply-To: <20240327150119.GA1502858@bhelgaas> References: <20240326131858.GA140624@workstation.local> <20240327150119.GA1502858@bhelgaas> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 27 Mar 2024 10:01:19 -0500 Bjorn Helgaas wrote: > On Tue, Mar 26, 2024 at 10:18:58PM +0900, Takashi Sakamoto wrote: > > On Mon, Mar 25, 2024 at 09:41:49AM -0500, Bjorn Helgaas wrote: > > > So even without this patch, you are able to pass the FW643 to a VM > > > with VFIO, and you don't see any issues caused by VFIO resetting the > > > device? > > > > Absolutely yes, at least in my VM, for recent years to maintain Linux > > FireWire subsystem and ALSA firewire stack. > > So there must be something different between your system and Edmund's. > Maybe we can refine the quirk so it avoids the SBR on Edmund's system > but not yours. > > Can you both collect the output of "sudo lspci -vvv" so we can try to > figure out the difference? Also a complete dmesg log would be helpful > and would contain DMI information that we might need if this is > firmware dependent. The original patch proposed for this gave me the impression that this was a device used on various old Mac systems, not likely applicable to a general purpose plug-in card. Given the expanded use case, I'd suggest reverting the patch. I think we need significantly more exhaustive testing on the afflicted system to understand whether this is an issue with the endpoint, the root port, the BIOS, etc. In the meantime, or maybe as a permanent solution, Edmund can make use of the reset_method interface in pci-syfs to restrict the available reset methods for the device rather than risk removing a reset mechanism identified as working by other users. My 2 cents. Thanks, Alex