Re: [PATCH 01/19] PCI: endpoint: Introduce pci_epc_check_func()

Bjorn Helgaas
2024-03-29T12:33:37Z

On Fri, Mar 29, 2024 at 06:09:27PM +0900, Damien Le Moal wrote:
> Introduce the small epc core helper function pci_epc_check_func() to
> check that an epc pointer, a physical function number and a virtual
> function number are all valid. This avoids repeating the code pattern:

Can you rename pci_epc_check_func() to something that suggests an
assertion that can be either true or false? "Check" doesn't give a
hint about what a "true" return means. Maybe "valid_func" or similar?

Bjorn