Re: [net-next PATCH 00/15] eth: fbnic: Add network driver for Meta Platforms Host Network Interface

Bjorn Helgaas
2024-04-03T20:42:33Z

On Wed, Apr 03, 2024 at 01:08:24PM -0700, Alexander Duyck wrote:
> This patch set includes the necessary patches to enable basic Tx and Rx
> over the Meta Platforms Host Network Interface. To do this we introduce a
> new driver and driver and directories in the form of
> "drivers/net/ethernet/meta/fbnic".

> PCI: Add Meta Platforms vendor ID
> eth: fbnic: add scaffolding for Meta's NIC driver
> eth: fbnic: Allocate core device specific structures and devlink interface
> eth: fbnic: Add register init to set PCIe/Ethernet device config
> eth: fbnic: add message parsing for FW messages
> eth: fbnic: add FW communication mechanism
> eth: fbnic: allocate a netdevice and napi vectors with queues
> eth: fbnic: implement Tx queue alloc/start/stop/free
> eth: fbnic: implement Rx queue alloc/start/stop/free
> eth: fbnic: Add initial messaging to notify FW of our presence
> eth: fbnic: Enable Ethernet link setup
> eth: fbnic: add basic Tx handling
> eth: fbnic: add basic Rx handling
> eth: fbnic: add L2 address programming
> eth: fbnic: write the TCAM tables used for RSS control and Rx to host

Random mix of initial caps in subjects. Also kind of a mix of initial
caps in comments, e.g.,

$ grep -Er "^\s+/\*" drivers/net/ethernet/meta/fbnic/

I didn't bother to figure out which patch these typos were in:

$ codespell drivers/net/ethernet/meta/fbnic/
drivers/net/ethernet/meta/fbnic/fbnic_pci.c:452: ot ==> to, of, or
drivers/net/ethernet/meta/fbnic/fbnic_pci.c:479: Reenable ==> Re-enable
drivers/net/ethernet/meta/fbnic/fbnic_txrx.c:569: caclulation ==> calculation
drivers/net/ethernet/meta/fbnic/fbnic_fw.c:740: conents ==> contents
drivers/net/ethernet/meta/fbnic/fbnic_txrx.h:19: cachline ==> cacheline