From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D24E13C90B for ; Tue, 7 May 2024 08:28:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715070519; cv=none; b=fDK7CFwt18Gi/aXjf7c7uOwA+4g184tzyg87sktWfJ3CtdgVA7VDoN3e4KW52E704DMEq8ABpS1y6m+FhokMcC7gbSpQBxA20sNzPP+xZ2zjXOs71/mW0SQTRPfR8pKmrnF6/gyUU7VgbfPN8sfKrMZccHfIH5PcU9x3piXO6Zc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715070519; c=relaxed/simple; bh=WAA10rA6qRqoYCr9XeTblOpVslB6CTUD6a/rB8ts6T8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bmtojqzZ2TjJ93WQub2NXaGOVI6wAA7J+zLXwpH/rTMw0GPeaUSXOab/EbvPRq4a6nl8oVjRRYPOYlQmxnculUqP++vhoyZx0iKcx0J7aZltIBX8MmU4MTqgAonKoHpsnKCuZlh/vGysOkptk/96fMp9A+tQKkIbsAF9+wB4pD8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=WvMWLB7E; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="WvMWLB7E" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1ec4b2400b6so23578645ad.3 for ; Tue, 07 May 2024 01:28:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1715070518; x=1715675318; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=GVgauUSBhCFoJsX8lOkvxxApBqvEtasgyEBvsQiV6aQ=; b=WvMWLB7E7Vioc78gLbcP+uIOdjLgNFyZB9fYMLjyHdQ0K/0s8XVqxUsxSNp0SwnhBV Po0ygzSSPvuKNYBuIEZ2qLhJWTMtXEQbsEe73BhDSODBIRXflIFkEtO0SBpCi0mv0Uzx 6BvDm5B7Ahhp0Py7XxqJ0UTrhB7dH4Z6H5nK9unsRMCxZoM/zOBWuQQUJBApbXYghm3l 0sKXt9B/QNEQJ7espVI/0Kyw2HJLvOPCDBb7R0Ldawusan1I9QmafSd2GQKsXYKrt+Yt p27GqajK0LK4LsoicOAz1oiQrze7N8KJ37oTXJpIMXS3iXAi7+I5fme9w4cEPYqsL/FU rqnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715070518; x=1715675318; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GVgauUSBhCFoJsX8lOkvxxApBqvEtasgyEBvsQiV6aQ=; b=YeGkOJS3OK44Ol+6koJz1HXSSEVOh9Y29CY4vlDICujC28WtkNpnxxsW0AyDXr0iQN aLd7raNZwq9qwtSv3/tfljOkqpHLMFchAF4aYWpaAIHTOa3grZ/SM8zKwzKNxHCiGXKB OHwqiKBNcvJ+O+kDJ9rNWYphb+qeOaP9LvG99p/J6nd7TXWwQMNmxACe427ygclX65kd gv8Po09p3mMyToJlYCqB405uys+xZz5sFQsEw+ePvDjMqhQ/yV0Ap9UZQjgN1QcyV/8Q Wkrnth6i7NsuNcX9auevde7kMXNVTruIC2z1ycEsti/KzOHyB8rqR6XD9CI51ttMaZOS zu3w== X-Forwarded-Encrypted: i=1; AJvYcCWXJyXcjgDLguQOo5r3P623ItozKKFQwiNVSc6C7Iobk0yv1tkjOjRfIjOLz7p80GbIlDz2bjyDlNYbVjgxqISv7FwKOlM013Z3 X-Gm-Message-State: AOJu0YwKu0V5QX8poMuJcSjT6XEOFdLlG04cqlCXb4YsiMy+fzqDWA+q RHdB1yPU4tK3KI4cbUP2Vs6v/X4yahWjNjcZ+YsTFcGwqDGDjMtHwSlxeBYezQ== X-Google-Smtp-Source: AGHT+IFkZxsg9zZ8uGCj6F9b96ztkp16VI7pxyk7k4qDQRuZ3fJBvMiqX1TfN7jL1VUt3SzWbyr1LA== X-Received: by 2002:a17:902:ce8a:b0:1e4:9ad5:a666 with SMTP id f10-20020a170902ce8a00b001e49ad5a666mr15845336plg.25.1715070517573; Tue, 07 May 2024 01:28:37 -0700 (PDT) Received: from thinkpad ([117.213.100.197]) by smtp.gmail.com with ESMTPSA id jb13-20020a170903258d00b001ec4ed47ddesm9603688plb.86.2024.05.07.01.28.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 01:28:37 -0700 (PDT) Date: Tue, 7 May 2024 13:58:22 +0530 From: Manivannan Sadhasivam To: Linus Walleij Cc: Andy Shevchenko , Frank Li , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-omap@vger.kernel.org, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-amlogic@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-tegra@vger.kernel.org, Vignesh Raghavendra , Siddharth Vadapalli , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Richard Zhu , Lucas Stach , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Yue Wang , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Xiaowei Song , Binghui Wang , Thierry Reding , Jonathan Hunter , Thomas Petazzoni , Pali =?iso-8859-1?Q?Roh=E1r?= Subject: Re: [PATCH v3 4/5] PCI: imx6: Convert to agnostic GPIO API Message-ID: <20240507082822.GA6659@thinkpad> References: <20240429102510.2665280-1-andriy.shevchenko@linux.intel.com> <20240429102510.2665280-5-andriy.shevchenko@linux.intel.com> <20240507081441.GA6025@thinkpad> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240507081441.GA6025@thinkpad> On Tue, May 07, 2024 at 01:44:56PM +0530, Manivannan Sadhasivam wrote: > On Mon, May 06, 2024 at 02:10:24PM +0200, Linus Walleij wrote: > > On Mon, Apr 29, 2024 at 12:25 PM Andy Shevchenko > > wrote: > > > > > The of_gpio.h is going to be removed. In preparation of that convert > > > the driver to the agnostic API. > > > > > > Reviewed-by: Manivannan Sadhasivam > > > Reviewed-by: Frank Li > > > Signed-off-by: Andy Shevchenko > > > > I think there is a bug here, the code is respecting the OF property > > "reset-gpio-active-high" > > but the code in drivers/gpio/gpiolib-of.h actually has a quirk for > > this so you can just > > delete all the active high handling and rely on 1 = asserted and 0 = > > deasserted when > > using GPIO descriptors. > > > > Wow... > > So this bug is present even before this series, right? > > > Just delete this thing: > > imx6_pcie->gpio_active_high = of_property_read_bool(node, > > "reset-gpio-active-high"); > > But this is just a bandaid IMO. The flag for the PERST# GPIO should be properly > set in the board dts as per the board design. > Hmm, no. I was confused by the property. But this quirk in gpiolib-of.c is going to be applied while changing the GPIO state also or just during request time? - Mani -- மணிவண்ணன் சதாசிவம்