From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6F9E3BBEA for ; Wed, 15 May 2024 20:57:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715806657; cv=none; b=SEv9OiAcCK0Bqo0gvKhKwA3au/FnN9nD8DdQtyVi9I/iQ1OeAuVgzUDHV9/INzI1UVOhTSlLxtNZi8kbAWlBDSxzCa8eDP2b6npV9GH7fXq2joFb4Ojp1qohyEbcERUVyyVQxLi7hH44ukYDHWK80/wnzVAr/9+EX7b+5fEADFk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715806657; c=relaxed/simple; bh=iD1gc3+Wt14qW5hJ3ZyQXWD9Xptwr3gLAOqU2wZvQiE=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition:In-Reply-To; b=hsRmSyNUrn67DBAViXq7YI6vJcqUTcMzhQ8CwpS3HlmsoFAIg66nXvqNOFWdLQXP1R1s8IzVOjBlu07jJC3v/OBjb8UtzoP7rS7C7GzvIzDUI1WmRlerV2o37P1qUYhTlNu2dPYK0qghDhfJJJr2CHKmNW/B+DONzZtonUafBx0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ZFibrt+W; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ZFibrt+W" Received: by smtp.kernel.org (Postfix) with ESMTPSA id ED56FC32781; Wed, 15 May 2024 20:57:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715806657; bh=iD1gc3+Wt14qW5hJ3ZyQXWD9Xptwr3gLAOqU2wZvQiE=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=ZFibrt+WUXeF0xAks7MbCyZQTXKQhpkVvrCHmz6l/T1UFIsdkXrOMbw96g3/35xhE yQftSpa7lT6HUOxRVK83TB53MKaRmXH8tVYdyvjTUXmGKFCQ2NMarVOl8yLnoDUwfP blLqAhmx5aOlJ4nBHBzJDS6J6hdZ2LwcbEs+66tRU4wcAEsysaaDxWpEQE01WLvh1d uBIIpsSJm0sWG4E5H3/oJVDYzJEGChgYIbuZVL8PNNuR6lGuxwYhV7h9DlvKV/JVjE dKehZ/wmC7vNyXu2rHMDvdNTj1WUh+YI52Htf0gd70X2rmVfWAvwVACSX6qMh9jRPX 0Q1Rv9MJ/DDJA== Date: Wed, 15 May 2024 15:57:35 -0500 From: Bjorn Helgaas To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Cc: Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Heiko Stuebner , Lei Chuanhua , Manivannan Sadhasivam , Jesper Nilsson , Nobuhiro Iwamatsu , Yoshihiro Shimoda , Serge Semin , Damien Le Moal , Rob Herring , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v2] PCI: dw-rockchip: Add error messages in .probe()s error paths Message-ID: <20240515205735.GA2137771@bhelgaas> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240227141256.413055-2-ukleinek@debian.org> On Tue, Feb 27, 2024 at 03:12:54PM +0100, Uwe Kleine-König wrote: > Drivers that silently fail to probe provide a bad user experience and > make it unnecessarily hard to debug such a failure. Fix it by using > dev_err_probe() instead of a plain return. > > Reviewed-by: Heiko Stuebner > Signed-off-by: Uwe Kleine-König Krzysztof applied this to pci/controller/rockchip with Reviewed-by from Jesper and Mani, but his outgoing mail queue got stuck. Trying to squeeze into v6.9. > --- > Hello, > > changes since (implicit) v1, sent with Message-Id: > 20240227111837.395422-2-ukleinek@debian.org: > > - use dev instead of rockchip->pci.dev as noticed by Serge Semin. > - added Reviewed-by: tag for Heiko. I assume he agrees to above > improvement and adding the tag despite the change is fine. > > Best regards > Uwe > > drivers/pci/controller/dwc/pcie-dw-rockchip.c | 21 ++++++++++++------- > 1 file changed, 13 insertions(+), 8 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pcie-dw-rockchip.c b/drivers/pci/controller/dwc/pcie-dw-rockchip.c > index d6842141d384..a13ca83ce260 100644 > --- a/drivers/pci/controller/dwc/pcie-dw-rockchip.c > +++ b/drivers/pci/controller/dwc/pcie-dw-rockchip.c > @@ -225,11 +225,15 @@ static int rockchip_pcie_clk_init(struct rockchip_pcie *rockchip) > > ret = devm_clk_bulk_get_all(dev, &rockchip->clks); > if (ret < 0) > - return ret; > + return dev_err_probe(dev, ret, "failed to get clocks\n"); > > rockchip->clk_cnt = ret; > > - return clk_bulk_prepare_enable(rockchip->clk_cnt, rockchip->clks); > + ret = clk_bulk_prepare_enable(rockchip->clk_cnt, rockchip->clks); > + if (ret) > + return dev_err_probe(dev, ret, "failed to enable clocks\n"); > + > + return 0; > } > > static int rockchip_pcie_resource_get(struct platform_device *pdev, > @@ -237,12 +241,14 @@ static int rockchip_pcie_resource_get(struct platform_device *pdev, > { > rockchip->apb_base = devm_platform_ioremap_resource_byname(pdev, "apb"); > if (IS_ERR(rockchip->apb_base)) > - return PTR_ERR(rockchip->apb_base); > + return dev_err_probe(&pdev->dev, PTR_ERR(rockchip->apb_base), > + "failed to map apb registers\n"); > > rockchip->rst_gpio = devm_gpiod_get_optional(&pdev->dev, "reset", > GPIOD_OUT_HIGH); > if (IS_ERR(rockchip->rst_gpio)) > - return PTR_ERR(rockchip->rst_gpio); > + return dev_err_probe(&pdev->dev, PTR_ERR(rockchip->rst_gpio), > + "failed to get reset gpio\n"); > > rockchip->rst = devm_reset_control_array_get_exclusive(&pdev->dev); > if (IS_ERR(rockchip->rst)) > @@ -320,10 +326,9 @@ static int rockchip_pcie_probe(struct platform_device *pdev) > rockchip->vpcie3v3 = NULL; > } else { > ret = regulator_enable(rockchip->vpcie3v3); > - if (ret) { > - dev_err(dev, "failed to enable vpcie3v3 regulator\n"); > - return ret; > - } > + if (ret) > + return dev_err_probe(dev, ret, > + "failed to enable vpcie3v3 regulator\n"); > } > > ret = rockchip_pcie_phy_init(rockchip); > > base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d > -- > 2.43.0 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel