Re: [PATCH v2 2/3] PCI/NPEM: Add Native PCIe Enclosure Management support

Mariusz Tkaczyk
2024-06-14T13:40:58Z

On Tue, 28 May 2024 16:55:16 +0300 (EEST)
Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> wrote:

> > +#define PCI_NPEM_IND_SPEC_0 0x00800000
> > +#define PCI_NPEM_IND_SPEC_1 0x01000000
> > +#define PCI_NPEM_IND_SPEC_2 0x02000000
> > +#define PCI_NPEM_IND_SPEC_3 0x04000000
> > +#define PCI_NPEM_IND_SPEC_4 0x08000000
> > +#define PCI_NPEM_IND_SPEC_5 0x10000000
> > +#define PCI_NPEM_IND_SPEC_6 0x20000000
> > +#define PCI_NPEM_IND_SPEC_7 0x40000000
>
> Are these off-by-one, shouldn't that field go all the way to the last bit
> which is 0x80000000 (the field is 31:24)??

Yes, I made a mistake. Good catch!

Mariusz