Linux PCI subsystem development
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: FUJITA Tomonori <fujita.tomonori@gmail.com>
Cc: netdev@vger.kernel.org, andrew@lunn.ch, horms@kernel.org,
	jiri@resnulli.us, pabeni@redhat.com, linux@armlinux.org.uk,
	hfdevel@gmx.net, naveenm@marvell.com, jdamato@fastly.com,
	bhelgaas@google.com, linux-pci@vger.kernel.org
Subject: Re: [PATCH net-next v10 2/7] net: tn40xx: add pci driver for Tehuti Networks TN40xx chips
Date: Thu, 13 Jun 2024 17:25:22 -0700	[thread overview]
Message-ID: <20240613172522.2535254d@kernel.org> (raw)
In-Reply-To: <20240611045217.78529-3-fujita.tomonori@gmail.com>

On Tue, 11 Jun 2024 13:52:12 +0900 FUJITA Tomonori wrote:
> This just adds the scaffolding for an ethernet driver for Tehuti
> Networks TN40xx chips.

Reviewed-by: Jakub Kicinski <kuba@kernel.org>

Minor notes below

> +TEHUTI TN40XX ETHERNET DRIVER
> +M:	FUJITA Tomonori <fujita.tomonori@gmail.com>
> +L:	netdev@vger.kernel.org
> +S:	Supported

Keep in mind that Supported will soon mean you gotta run a test farm ;)
https://netdev.bots.linux.dev/devices.html


> +MODULE_DEVICE_TABLE(pci, tn40_id_table);
> +MODULE_AUTHOR("Tehuti networks");

I don't see sign-offs from anyone else, so you can either put yourself
as the author or just leave it out. People write code, not corporations.
IOW authorship != copyright.

  reply	other threads:[~2024-06-14  0:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-11  4:52 [PATCH net-next v10 0/7] add ethernet driver for Tehuti Networks TN40xx chips FUJITA Tomonori
2024-06-11  4:52 ` [PATCH net-next v10 1/7] PCI: add Edimax Vendor ID to pci_ids.h FUJITA Tomonori
2024-06-11 15:01   ` Bjorn Helgaas
2024-06-12  3:48     ` FUJITA Tomonori
2024-06-11  4:52 ` [PATCH net-next v10 2/7] net: tn40xx: add pci driver for Tehuti Networks TN40xx chips FUJITA Tomonori
2024-06-14  0:25   ` Jakub Kicinski [this message]
2024-06-14  2:50     ` FUJITA Tomonori
2024-06-13 16:14 ` [PATCH net-next v10 0/7] add ethernet " Joe Damato
2024-06-17 22:04   ` FUJITA Tomonori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240613172522.2535254d@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=bhelgaas@google.com \
    --cc=fujita.tomonori@gmail.com \
    --cc=hfdevel@gmx.net \
    --cc=horms@kernel.org \
    --cc=jdamato@fastly.com \
    --cc=jiri@resnulli.us \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=naveenm@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox